Skip to content

refactor(web): normalize z-index layering#38796

Merged
lyzno1 merged 5 commits into
mainfrom
codex/normalize-web-z-index
Jul 12, 2026
Merged

refactor(web): normalize z-index layering#38796
lyzno1 merged 5 commits into
mainfrom
codex/normalize-web-z-index

Conversation

@lyzno1

@lyzno1 lyzno1 commented Jul 12, 2026

Copy link
Copy Markdown
Member

Summary

  • align application dialogs and portalled pickers with the Dify UI overlay contract
  • remove redundant high z-index values while preserving feature-local paint order
  • replace legacy workflow graph layers with a single semantic nested-element layer and normalize old graph, paste, copy, and snippet paths
  • keep the existing RAG floating-panel layer because removing it would let later positioned panel siblings cover the surface

Regression safeguards

  • preserve the Agent Settings panel geometry while using the shared Dialog primitive and its theme-aware default backdrop
  • preserve the DSL warning tint paint order without a numeric z-index
  • retain React Flow ordering: selected containers resolve to 1000, nested nodes/edges/labels and the default connection line resolve to 1001
  • derive inserted snippet edge layers from the nodes final parent relationships, including roots moved into an Iteration or Loop
  • keep account and integrations close controls visually above their owning content through owner placement and DOM order

Verification

  • vpr dify#lint --quiet --fix --prune-suppressions
  • pnpm -C web type-check
  • 23 focused test files: 271 passed, 1 skipped
  • final focused recheck: 29 passed
  • default-backdrop follow-up: 9 passed
  • nested snippet regression suite: 7 files, 121 passed
  • git diff --check
  • local Next.js compilation succeeded; interactive browser smoke was blocked because the local API was not running (ECONNREFUSED)

Screenshots

Not available: the local web route requires a running API. The affected paint-order contracts are covered by focused tests and source-level stacking-context review.

Checklist

  • I added or updated behavior-focused tests for the changed workflow and dialog contracts.
  • I ran frontend lint and type-check validation.
  • Documentation update required.

From Codex

@github-actions github-actions Bot added the web This relates to changes on the web. label Jul 12, 2026
@codecov

codecov Bot commented Jul 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.30303% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.48%. Comparing base (6e5ba18) to head (9aa5dc1).

Files with missing lines Patch % Lines
...omponents/workflow/hooks/use-nodes-interactions.ts 13.33% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #38796      +/-   ##
==========================================
+ Coverage   85.47%   85.48%   +0.01%     
==========================================
  Files        5025     5025              
  Lines      273457   273456       -1     
  Branches    51259    51249      -10     
==========================================
+ Hits       233729   233760      +31     
+ Misses      35238    35206      -32     
  Partials     4490     4490              
Flag Coverage Δ
dify-ui 94.61% <ø> (ø)
web 85.17% <80.30%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1
lyzno1 marked this pull request as ready for review July 12, 2026 10:14
@lyzno1
lyzno1 enabled auto-merge July 12, 2026 10:14
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. refactor labels Jul 12, 2026
@lyzno1
lyzno1 added this pull request to the merge queue Jul 12, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 12, 2026
Merged via the queue into main with commit 1246aa7 Jul 12, 2026
37 of 38 checks passed
@lyzno1
lyzno1 deleted the codex/normalize-web-z-index branch July 12, 2026 14:30
BlueSkyXN added a commit to BlueSkyXN/dify that referenced this pull request Jul 12, 2026
* fix(web): improve marketplace install dialog accessibility (langgenius#38798)

* refactor(web): normalize z-index layering (langgenius#38796)

* fix(web): correct knowledge dialog draft state (langgenius#38794)

* fix(agent-v2): restore keyboard access to row actions (langgenius#38792)

* fix(web): split model selection and settings actions (langgenius#38797)

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

* fix: eagerly validate conversation on service-api and explore chat endpoints (langgenius#38801)

Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

---------

Signed-off-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
Co-authored-by: yyh <92089059+lyzno1@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Yufeng He <40085740+he-yufeng@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer refactor size:L This PR changes 100-499 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants