Update explore endpoints in libs to use v1 by jowlee · Pull Request #1539 · AudiusProject/audius-client

jowlee · 2022-06-30T16:28:48Z

Description

Update explore page to use new v1 endpoints

Relies on updated libs version
reference PRs:

Fixes PLAT-233

Dragons

Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?

How Has This Been Tested?

Ran locally against linked libs and discovery running against prod with (fixed) endpoint

How will this change be monitored?

For features that are critical or could fail silently please describe the monitoring/alerting being added.

Feature Flags

Are all new features properly feature flagged? Describe added feature flags.

audius-infra · 2022-06-30T16:36:34Z

Preview this change https://demo.audius.co/jowlee-explore

dylanjeffers

niceee

dylanjeffers · 2022-06-30T17:31:36Z

  const trackIds = tracks
    .filter(track => !track.user.is_deactivated)
-    .map((track: Track) => ({
+    .map((track: UserTrackMetadata) => ({


does const tracks = yield* call(...) not return UserTrackMetadata[] ? or are the types not defined in libs or something?

dylanjeffers · 2022-07-01T03:45:11Z

+      return tracks.map(adapter.makeTrack).filter(removeNullable)
+    } catch (e) {
+      console.error(e)
+      return []


just wondering what the error case is here, i guess seems like the pattern in the file?

Retuning [] causes the page to show zero tracks in this playlist - I'm not sure what the intended error behavior is.

audius-infra · 2022-07-11T20:38:11Z

Preview this change https://demo.audius.co/jowlee-explore

audius-infra · 2022-07-14T21:49:39Z

Preview this change https://demo.audius.co/jowlee-explore

audius-infra · 2022-07-15T12:34:22Z

Preview this change https://demo.audius.co/jowlee-explore

[a326ed1] [PAY-425] Fix optimistic trophy icon for supporting (#1586) Marcus Pasell [f760497] Remove antd table shadow pseudoelements (#1604) Kyle Shanks [6caebfb] Change WRITE_QUORUM_ENABLED to session flag (#1602) Theo Ilie [81837c8] Add shimmer effect to skeleton component (#1583) Kyle Shanks [91d638c] Update explore endpoints in libs to use v1 (#1539) Joseph Lee [bc5a32e] Change logout from sync to async due to SDK changes (#1567) nicoback2 [9ff7510] [PAY-432] Freeze balance briefly after sending a tip (#1599) Michael Piazza [3620262] Add main role (#1597) Sebastian Klingler [5ec991f] [PAY-422] Fix tip icon notification matrix color (#1594) Dylan Jeffers [6523977] [C-677] Fix profile-screen icon hit-slop and color (#1595) Dylan Jeffers [3265713] [C-679] Fix Probers (#1591) Sebastian Klingler [0493d99] [PAY-424] Remove search icon in user-lists (#1596) Dylan Jeffers [68d4ac4] [PAY-423] Fix matrix-mode send-tip web styles (#1593) Dylan Jeffers [fd39136] [PAY-426] Fix native large button icon sizing/spacing (#1592) Dylan Jeffers [b874da7] Limit prod mobile builds to main & release branches (#1590) Sebastian Klingler [462e032] [PAY-393] Fix active state animation on mobile SupportingTile (#1587) Michael Piazza [1f59819] [C-664] Add @audius/common (#1584) Dylan Jeffers [56e2a41] [C-427] Fix matrix mode color for dismiss feed-tip-tile button (#1588) Dylan Jeffers [8b74c18] Fix entity and solana types in web (#1585) Dylan Jeffers [3301e27] Fix sdk lazyload and upgrade to sdk 0.0.12 (#1581) Sebastian Klingler [c91f722] [CON-234] Add write quorum feature flag (#1576) Theo Ilie [e7dc144] Fix native milestone notification (#1575) Dylan Jeffers [9af0e95] [PAY-399] Fix reaction notification selection bug (#1573) Dylan Jeffers [13db0db] [C-674] Upgrade eslint, prettier, and plugins to latest (#1578) Dylan Jeffers [0285c7e] [PAY-414] Fix unsending reactions (#1582) Michael Piazza [dee8c96] Fix solana phantom provider types (#1580) Raymond Jacobson [29f97db] Fix solana sign message for Brave (#1579) Raymond Jacobson [6848f81] [PAY-415] Clicking tipping notifications goes to profile (#1574) Dylan Jeffers [ae44d1c] [C-409] Add eslint-config-audius, use in packages (#1570) Dylan Jeffers [8e39c2c] Fix sign-on action types (#1571) Dylan Jeffers [c3fb7f9] Remove extra lint step (#1572) Sebastian Klingler [ca26a53] Add ssh key for audius-infra write access (#1569) Sebastian Klingler [71fe7a8] [C-402] Add min version logic for the desktop app (#1568) Kyle Shanks [068c2f4] Fix jitter (#1566) Saliou Diallo [6db7532] [PAY-386] [PAY-387] Created Mobile + Web UIs for First Playlist Challenge (#1565) Reed [0c36c77] [C-667] Fix desktop build on mac (#1564) Raymond Jacobson [ba73747] [C-565] Add chain icon to collectibles card (#1563) Dylan Jeffers [09bb30a] Fix various mobile types (#1562) Dylan Jeffers [85ac517] [PAY-405] Fixed Claim Rewards Pill To Respect Optimizely Config (#1558) Reed [24de5e1] [C-581] Improve probers upload flow a11y (#1561) Dylan Jeffers [3f79f27] [C-575] Fix sentry and dev warnings (#1560) Dylan Jeffers [a533cce] [C-654] Improve web modal usage and performance (#1559) Dylan Jeffers [381cfcc] [C-400] Add logic for mobile app minimum version (#1555) Kyle Shanks [b996975] Upgrade CRA and webpack to v5 (#1508) Dylan Jeffers [981ef8b] [PAY-384] Created First Tip Challenge Mobile UI (#1554) Reed [d271051] Rework CI to use lerna bootstrap and singular npm install (#1553) Raymond Jacobson [0b51b21] v1.1.12 (#1552) Raymond Jacobson [7029175] Move CP of tar file to s3 step (#1550) Raymond Jacobson

This reverts commit 91d638c.

…1609)" This reverts commit 317e197.

This reverts commit 91d638c.

…1609)" This reverts commit 317e197.

…1609)" (#1669) This reverts commit 317e197.

[c3682b3] [C-780] Update AudiusBackend to work in native context (#1677) Dylan Jeffers [398093d] [C-781] Add minimum threshold to common password check (#1684) Kyle Shanks [5a66847] Ensure fetch calls are awaited so errors are caught (#1683) Sebastian Klingler [d597054] Make audiusBackend configurable for different environments (#1670) Sebastian Klingler [b5fa3fa] Fix native build with new metro-config dependencies (#1676) Dylan Jeffers [408a425] [C-771] Update native metro-config to enable @audius/sdk (#1671) Dylan Jeffers [afde38e] [PAY-416] Early access mode & feature flag refactor (#1654) Michael Piazza [3b28c7e] Fix typecheck for mobile after AudiusBackend ts migration (#1672) Sebastian Klingler [e5fbbb5] Revert "Revert "Update explore endpoints in libs to use v1 (#1539)" (#1609)" (#1669) Joseph Lee [237784b] Default endpoints to empty array instead of null (#1665) Marcus Pasell [175e5d6] Add ModalContentPages to stems (#1659) Marcus Pasell [fdadaac] fix mobile menu on narrow (#1664) nicoback2 [3e2b499] Convert AudiusBackend to typescript (#1650) Sebastian Klingler

jowlee requested a review from rickyrombo June 30, 2022 16:28

jowlee assigned dylanjeffers Jun 30, 2022

pull-request-size Bot added the size/M label Jun 30, 2022

dylanjeffers approved these changes Jul 1, 2022

View reviewed changes

rickyrombo approved these changes Jul 5, 2022

View reviewed changes

jowlee force-pushed the jowlee-explore branch from bce50a9 to 6c260ae Compare July 11, 2022 20:16

jowlee force-pushed the jowlee-explore branch from 6c260ae to b82256a Compare July 14, 2022 21:22

jowlee added 3 commits July 15, 2022 12:20

Update explore endpoints in libs to use v1

4aff7d9

Update lib call name

0e892bd

Fix lint

76f363d

jowlee force-pushed the jowlee-explore branch from 3f6d584 to 76f363d Compare July 15, 2022 12:20

jowlee merged commit 91d638c into main Jul 15, 2022

jowlee deleted the jowlee-explore branch July 15, 2022 12:42

jowlee added a commit that referenced this pull request Jul 18, 2022

Revert "Update explore endpoints in libs to use v1 (#1539)"

4490ac8

This reverts commit 91d638c.

jowlee added a commit that referenced this pull request Jul 18, 2022

Revert "Update explore endpoints in libs to use v1 (#1539)" (#1609)

317e197

This reverts commit 91d638c.

jowlee added a commit that referenced this pull request Jul 18, 2022

Revert "Revert "Update explore endpoints in libs to use v1 (#1539)" (#…

6686c3a

…1609)" This reverts commit 317e197.

sliptype pushed a commit that referenced this pull request Jul 18, 2022

Revert "Update explore endpoints in libs to use v1 (#1539)" (#1609)

411fb04

This reverts commit 91d638c.

jowlee added a commit that referenced this pull request Aug 3, 2022

Revert "Revert "Update explore endpoints in libs to use v1 (#1539)" (#…

c46ff38

…1609)" This reverts commit 317e197.

jowlee mentioned this pull request Aug 3, 2022

Update explore endpoints in libs to use v1 #1669

Merged

jowlee added a commit that referenced this pull request Aug 4, 2022

Revert "Revert "Update explore endpoints in libs to use v1 (#1539)" (#…

e5fbbb5

…1609)" (#1669) This reverts commit 317e197.

AudiusProject deleted a comment from linear Bot Sep 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update explore endpoints in libs to use v1#1539

Update explore endpoints in libs to use v1#1539
jowlee merged 3 commits into
mainfrom
jowlee-explore

jowlee commented Jun 30, 2022

Uh oh!

audius-infra commented Jun 30, 2022

Uh oh!

dylanjeffers left a comment

Uh oh!

dylanjeffers Jun 30, 2022

Uh oh!

dylanjeffers Jul 1, 2022

Uh oh!

jowlee Jul 1, 2022

Uh oh!

audius-infra commented Jul 11, 2022

Uh oh!

audius-infra commented Jul 14, 2022

Uh oh!

audius-infra commented Jul 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jowlee commented Jun 30, 2022

Description

Dragons

How Has This Been Tested?

How will this change be monitored?

Feature Flags

Uh oh!

audius-infra commented Jun 30, 2022

Uh oh!

dylanjeffers left a comment

Choose a reason for hiding this comment

Uh oh!

dylanjeffers Jun 30, 2022

Choose a reason for hiding this comment

Uh oh!

dylanjeffers Jul 1, 2022

Choose a reason for hiding this comment

Uh oh!

jowlee Jul 1, 2022

Choose a reason for hiding this comment

Uh oh!

audius-infra commented Jul 11, 2022

Uh oh!

audius-infra commented Jul 14, 2022

Uh oh!

audius-infra commented Jul 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants