This repository was archived by the owner on Oct 4, 2023. It is now read-only.
[C-427] Fix matrix mode color for dismiss feed-tip-tile button#1588
Merged
Conversation
rickyrombo
approved these changes
Jul 14, 2022
| @@ -1,3 +1,4 @@ | |||
| ENVIRONMENT=staging | |||
Contributor
There was a problem hiding this comment.
This doesn't feel right - shouldn't staging be separate from dev?
Contributor
Author
There was a problem hiding this comment.
yeah i agree, will update to be development, and then do a check for not prod!
| import { SettingsRowContent } from './SettingsRowContent' | ||
| import { SettingsRowDescription } from './SettingsRowDescription' | ||
|
|
||
| const isStaging = Config.ENVIRONMENT === 'staging' |
Contributor
There was a problem hiding this comment.
Maybe instead we can check for Config.ENVIRONMENT !=== 'production' or something?
| @@ -1,4 +1,4 @@ | |||
| REACT_APP_ENVIRONMENT= | |||
| REACT_APP_ENVIRONMENT=staging | |||
Contributor
There was a problem hiding this comment.
Does this get overridden by configureLocalDev or no?
Contributor
|
I like the idea wrt the matrix mode being enabled on staging - though I think it might also work to give all of us tons of $AUDIO via the spout instead to exercise that enable matrix mode path |
Contributor
Author
Agreed with that, would help with a bunch of other things too |
Collaborator
|
Preview this change https://demo.audius.co/dj-c-427-fix-matrix-mode-close-feed-tip-tile |
audius-infra
pushed a commit
that referenced
this pull request
Jul 16, 2022
[a326ed1] [PAY-425] Fix optimistic trophy icon for supporting (#1586) Marcus Pasell [f760497] Remove antd table shadow pseudoelements (#1604) Kyle Shanks [6caebfb] Change WRITE_QUORUM_ENABLED to session flag (#1602) Theo Ilie [81837c8] Add shimmer effect to skeleton component (#1583) Kyle Shanks [91d638c] Update explore endpoints in libs to use v1 (#1539) Joseph Lee [bc5a32e] Change logout from sync to async due to SDK changes (#1567) nicoback2 [9ff7510] [PAY-432] Freeze balance briefly after sending a tip (#1599) Michael Piazza [3620262] Add main role (#1597) Sebastian Klingler [5ec991f] [PAY-422] Fix tip icon notification matrix color (#1594) Dylan Jeffers [6523977] [C-677] Fix profile-screen icon hit-slop and color (#1595) Dylan Jeffers [3265713] [C-679] Fix Probers (#1591) Sebastian Klingler [0493d99] [PAY-424] Remove search icon in user-lists (#1596) Dylan Jeffers [68d4ac4] [PAY-423] Fix matrix-mode send-tip web styles (#1593) Dylan Jeffers [fd39136] [PAY-426] Fix native large button icon sizing/spacing (#1592) Dylan Jeffers [b874da7] Limit prod mobile builds to main & release branches (#1590) Sebastian Klingler [462e032] [PAY-393] Fix active state animation on mobile SupportingTile (#1587) Michael Piazza [1f59819] [C-664] Add @audius/common (#1584) Dylan Jeffers [56e2a41] [C-427] Fix matrix mode color for dismiss feed-tip-tile button (#1588) Dylan Jeffers [8b74c18] Fix entity and solana types in web (#1585) Dylan Jeffers [3301e27] Fix sdk lazyload and upgrade to sdk 0.0.12 (#1581) Sebastian Klingler [c91f722] [CON-234] Add write quorum feature flag (#1576) Theo Ilie [e7dc144] Fix native milestone notification (#1575) Dylan Jeffers [9af0e95] [PAY-399] Fix reaction notification selection bug (#1573) Dylan Jeffers [13db0db] [C-674] Upgrade eslint, prettier, and plugins to latest (#1578) Dylan Jeffers [0285c7e] [PAY-414] Fix unsending reactions (#1582) Michael Piazza [dee8c96] Fix solana phantom provider types (#1580) Raymond Jacobson [29f97db] Fix solana sign message for Brave (#1579) Raymond Jacobson [6848f81] [PAY-415] Clicking tipping notifications goes to profile (#1574) Dylan Jeffers [ae44d1c] [C-409] Add eslint-config-audius, use in packages (#1570) Dylan Jeffers [8e39c2c] Fix sign-on action types (#1571) Dylan Jeffers [c3fb7f9] Remove extra lint step (#1572) Sebastian Klingler [ca26a53] Add ssh key for audius-infra write access (#1569) Sebastian Klingler [71fe7a8] [C-402] Add min version logic for the desktop app (#1568) Kyle Shanks [068c2f4] Fix jitter (#1566) Saliou Diallo [6db7532] [PAY-386] [PAY-387] Created Mobile + Web UIs for First Playlist Challenge (#1565) Reed [0c36c77] [C-667] Fix desktop build on mac (#1564) Raymond Jacobson [ba73747] [C-565] Add chain icon to collectibles card (#1563) Dylan Jeffers [09bb30a] Fix various mobile types (#1562) Dylan Jeffers [85ac517] [PAY-405] Fixed Claim Rewards Pill To Respect Optimizely Config (#1558) Reed [24de5e1] [C-581] Improve probers upload flow a11y (#1561) Dylan Jeffers [3f79f27] [C-575] Fix sentry and dev warnings (#1560) Dylan Jeffers [a533cce] [C-654] Improve web modal usage and performance (#1559) Dylan Jeffers [381cfcc] [C-400] Add logic for mobile app minimum version (#1555) Kyle Shanks [b996975] Upgrade CRA and webpack to v5 (#1508) Dylan Jeffers [981ef8b] [PAY-384] Created First Tip Challenge Mobile UI (#1554) Reed [d271051] Rework CI to use lerna bootstrap and singular npm install (#1553) Raymond Jacobson [0b51b21] v1.1.12 (#1552) Raymond Jacobson [7029175] Move CP of tar file to s3 step (#1550) Raymond Jacobson
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IconButtonfor web close button for better a11y and use of stemsDragons
Got to make sure matrix is only avail on staging with this change, which i think is the case since it's checking for 'staging', which prod config doesn't have