This repository was archived by the owner on Oct 4, 2023. It is now read-only.
Make audiusBackend configurable for different environments#1670
Merged
Conversation
dylanjeffers
approved these changes
Aug 4, 2022
dylanjeffers
left a comment
Contributor
There was a problem hiding this comment.
awesome stuff! so just wondering if the goal is to move audius-backend to common after this?
| import { Dispatch } from 'redux' | ||
|
|
||
| import imageProfilePicEmpty from 'assets/img/imageProfilePicEmpty2X.png' | ||
| import imageProfilePicEmpty from 'common/assets/img/imageProfilePicEmpty2X.png' |
Contributor
There was a problem hiding this comment.
clutch that images can be reused
|
|
||
| if (cache) CIDCache.add(cid, url) | ||
| // Avoid garbage collection by keeping a few images in an in-mem array | ||
| const image = new Image() |
Contributor
There was a problem hiding this comment.
this compat with native?
Contributor
Author
There was a problem hiding this comment.
Oooo I don't think so, good catch
Let me think about how to address this
| () => {} | ||
| ) | ||
|
|
||
| const url = nativeMobile |
| return NATIVE_MOBILE && process.env.REACT_APP_ENVIRONMENT === 'production' | ||
| ? AUDIUS_ORIGIN | ||
| async function _getHostUrl() { | ||
| return nativeMobile && process.env.REACT_APP_ENVIRONMENT === 'production' |
Contributor
There was a problem hiding this comment.
i kinda forget if process exits like this in native mobile, seemingly REACT_APP wouldn't since thats a CRA thing?
Contributor
Author
There was a problem hiding this comment.
Yeah I just missed this one, updated now!
audius-infra
pushed a commit
that referenced
this pull request
Aug 6, 2022
[c3682b3] [C-780] Update AudiusBackend to work in native context (#1677) Dylan Jeffers [398093d] [C-781] Add minimum threshold to common password check (#1684) Kyle Shanks [5a66847] Ensure fetch calls are awaited so errors are caught (#1683) Sebastian Klingler [d597054] Make audiusBackend configurable for different environments (#1670) Sebastian Klingler [b5fa3fa] Fix native build with new metro-config dependencies (#1676) Dylan Jeffers [408a425] [C-771] Update native metro-config to enable @audius/sdk (#1671) Dylan Jeffers [afde38e] [PAY-416] Early access mode & feature flag refactor (#1654) Michael Piazza [3b28c7e] Fix typecheck for mobile after AudiusBackend ts migration (#1672) Sebastian Klingler [e5fbbb5] Revert "Revert "Update explore endpoints in libs to use v1 (#1539)" (#1609)" (#1669) Joseph Lee [237784b] Default endpoints to empty array instead of null (#1665) Marcus Pasell [175e5d6] Add ModalContentPages to stems (#1659) Marcus Pasell [fdadaac] fix mobile menu on narrow (#1664) nicoback2 [3e2b499] Convert AudiusBackend to typescript (#1650) Sebastian Klingler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
audiusBackendfrom using env vars to accepting parameters for configuration values. This allows us to useconfigin react native instead of process.env. Also refactors audiusBackend into a function instead of a static classaudiusBackendInstance. Updates all references in web fromAudiusBackend->audiusBackendInstance. Once we have a correspondingaudiusBackendInstancein native, we will probably have to pass these instances into the relevant sagas, etc.audiusBackendto common in preparation for movingaudiusBackendto common itselfwindowinaudiusBackend, there are still a couple but I believe they are limited to claiming rewards. We can address these when we build out screensIn following prs will:
audiusBackendinto @audius/commonaudiusBackendwith the new libs typesDragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
Pretty big structural changes, smoke tested locally but definitely want to do some through testing once on stage
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.
Feature Flags
Are all new features properly feature flagged? Describe added feature flags.