[C-400] Add logic for mobile app minimum version by Kyle-Shanks · Pull Request #1555 · AudiusProject/audius-client

Kyle-Shanks · 2022-07-07T18:57:46Z

Description

Add remote config key
Add UpdateRequiredScreen
Add useUpdateRequired hook for mobile

Dragons

N/A

How Has This Been Tested?

Need to test on a device to make sure that the link to the app store and play store works

How will this change be monitored?

N/A

Feature Flags

N/A

Kyle-Shanks · 2022-07-07T19:02:41Z

Oh also, need to confirm the update copy 😅

audius-infra · 2022-07-07T19:11:37Z

Preview this change https://demo.audius.co/kj-Mobile-min-app-version

dylanjeffers

looks great! main qs i think would be good to figure out is react-navigation usage, useLink, and useMemo

dylanjeffers · 2022-07-07T19:07:37Z

  <true/>
+	<key>LSApplicationQueriesSchemes</key>
+	<array>
+		<string>itms-apps</string>


cool, just curious what this is?

This is needed for linking out to the app store. Not entirely sure what it's for, but seems like it's allowing itms-apps links

dylanjeffers · 2022-07-07T19:08:42Z

+  }
+
+  if (versionInfo.major > minVersionInfo.major) return false
+  if (versionInfo.major < minVersionInfo.major) return true


wow this is a cool function, very clean too

Love this function but also a suggestion, we could use the semver package to do the comparison and avoid doing it manually: https://www.npmjs.com/package/semver

Fair point. Wasnt sure if it was worth adding, but will add

dylanjeffers · 2022-07-07T19:13:33Z

+    textAlign: 'center',
+    textShadowOffset: { height: 2, width: 0 },
+    textShadowRadius: 4,
+    textShadowColor: 'rgba(162,47,235,0.2)'


no worries at all, but is this a standard value we use for things? might be cool to add text-shadow to our theme? also is this compatible with all theme modes?

audius-infra · 2022-07-07T21:04:05Z

Preview this change https://demo.audius.co/kj-Mobile-min-app-version

sliptype

Nice work! 🔥

sliptype · 2022-07-08T15:17:31Z

+  }
+
+  if (versionInfo.major > minVersionInfo.major) return false
+  if (versionInfo.major < minVersionInfo.major) return true


Love this function but also a suggestion, we could use the semver package to do the comparison and avoid doing it manually: https://www.npmjs.com/package/semver

audius-infra · 2022-07-08T16:32:24Z

Preview this change https://demo.audius.co/kj-Mobile-min-app-version

[99a7643] Ignore npm i scripts sliptype [e866679] Commit package changes sliptype [fa71006] Merge branch 'main' into sk-circleci-ssh sliptype [1de7edb] Test ssh key sliptype [89c54b3] Add ssh key sliptype [068c2f4] Fix jitter (#1566) Saliou Diallo [6db7532] [PAY-386] [PAY-387] Created Mobile + Web UIs for First Playlist Challenge (#1565) Reed [0c36c77] [C-667] Fix desktop build on mac (#1564) Raymond Jacobson [ba73747] [C-565] Add chain icon to collectibles card (#1563) Dylan Jeffers [09bb30a] Fix various mobile types (#1562) Dylan Jeffers [85ac517] [PAY-405] Fixed Claim Rewards Pill To Respect Optimizely Config (#1558) Reed [24de5e1] [C-581] Improve probers upload flow a11y (#1561) Dylan Jeffers [3f79f27] [C-575] Fix sentry and dev warnings (#1560) Dylan Jeffers [a533cce] [C-654] Improve web modal usage and performance (#1559) Dylan Jeffers [381cfcc] [C-400] Add logic for mobile app minimum version (#1555) Kyle Shanks [b996975] Upgrade CRA and webpack to v5 (#1508) Dylan Jeffers [981ef8b] [PAY-384] Created First Tip Challenge Mobile UI (#1554) Reed [d271051] Rework CI to use lerna bootstrap and singular npm install (#1553) Raymond Jacobson [0b51b21] v1.1.12 (#1552) Raymond Jacobson [7029175] Move CP of tar file to s3 step (#1550) Raymond Jacobson

[4563c71] Test typo sliptype [99a7643] Ignore npm i scripts sliptype [e866679] Commit package changes sliptype [fa71006] Merge branch 'main' into sk-circleci-ssh sliptype [1de7edb] Test ssh key sliptype [89c54b3] Add ssh key sliptype [068c2f4] Fix jitter (#1566) Saliou Diallo [6db7532] [PAY-386] [PAY-387] Created Mobile + Web UIs for First Playlist Challenge (#1565) Reed [0c36c77] [C-667] Fix desktop build on mac (#1564) Raymond Jacobson [ba73747] [C-565] Add chain icon to collectibles card (#1563) Dylan Jeffers [09bb30a] Fix various mobile types (#1562) Dylan Jeffers [85ac517] [PAY-405] Fixed Claim Rewards Pill To Respect Optimizely Config (#1558) Reed [24de5e1] [C-581] Improve probers upload flow a11y (#1561) Dylan Jeffers [3f79f27] [C-575] Fix sentry and dev warnings (#1560) Dylan Jeffers [a533cce] [C-654] Improve web modal usage and performance (#1559) Dylan Jeffers [381cfcc] [C-400] Add logic for mobile app minimum version (#1555) Kyle Shanks [b996975] Upgrade CRA and webpack to v5 (#1508) Dylan Jeffers [981ef8b] [PAY-384] Created First Tip Challenge Mobile UI (#1554) Reed [d271051] Rework CI to use lerna bootstrap and singular npm install (#1553) Raymond Jacobson [0b51b21] v1.1.12 (#1552) Raymond Jacobson [7029175] Move CP of tar file to s3 step (#1550) Raymond Jacobson

[a326ed1] [PAY-425] Fix optimistic trophy icon for supporting (#1586) Marcus Pasell [f760497] Remove antd table shadow pseudoelements (#1604) Kyle Shanks [6caebfb] Change WRITE_QUORUM_ENABLED to session flag (#1602) Theo Ilie [81837c8] Add shimmer effect to skeleton component (#1583) Kyle Shanks [91d638c] Update explore endpoints in libs to use v1 (#1539) Joseph Lee [bc5a32e] Change logout from sync to async due to SDK changes (#1567) nicoback2 [9ff7510] [PAY-432] Freeze balance briefly after sending a tip (#1599) Michael Piazza [3620262] Add main role (#1597) Sebastian Klingler [5ec991f] [PAY-422] Fix tip icon notification matrix color (#1594) Dylan Jeffers [6523977] [C-677] Fix profile-screen icon hit-slop and color (#1595) Dylan Jeffers [3265713] [C-679] Fix Probers (#1591) Sebastian Klingler [0493d99] [PAY-424] Remove search icon in user-lists (#1596) Dylan Jeffers [68d4ac4] [PAY-423] Fix matrix-mode send-tip web styles (#1593) Dylan Jeffers [fd39136] [PAY-426] Fix native large button icon sizing/spacing (#1592) Dylan Jeffers [b874da7] Limit prod mobile builds to main & release branches (#1590) Sebastian Klingler [462e032] [PAY-393] Fix active state animation on mobile SupportingTile (#1587) Michael Piazza [1f59819] [C-664] Add @audius/common (#1584) Dylan Jeffers [56e2a41] [C-427] Fix matrix mode color for dismiss feed-tip-tile button (#1588) Dylan Jeffers [8b74c18] Fix entity and solana types in web (#1585) Dylan Jeffers [3301e27] Fix sdk lazyload and upgrade to sdk 0.0.12 (#1581) Sebastian Klingler [c91f722] [CON-234] Add write quorum feature flag (#1576) Theo Ilie [e7dc144] Fix native milestone notification (#1575) Dylan Jeffers [9af0e95] [PAY-399] Fix reaction notification selection bug (#1573) Dylan Jeffers [13db0db] [C-674] Upgrade eslint, prettier, and plugins to latest (#1578) Dylan Jeffers [0285c7e] [PAY-414] Fix unsending reactions (#1582) Michael Piazza [dee8c96] Fix solana phantom provider types (#1580) Raymond Jacobson [29f97db] Fix solana sign message for Brave (#1579) Raymond Jacobson [6848f81] [PAY-415] Clicking tipping notifications goes to profile (#1574) Dylan Jeffers [ae44d1c] [C-409] Add eslint-config-audius, use in packages (#1570) Dylan Jeffers [8e39c2c] Fix sign-on action types (#1571) Dylan Jeffers [c3fb7f9] Remove extra lint step (#1572) Sebastian Klingler [ca26a53] Add ssh key for audius-infra write access (#1569) Sebastian Klingler [71fe7a8] [C-402] Add min version logic for the desktop app (#1568) Kyle Shanks [068c2f4] Fix jitter (#1566) Saliou Diallo [6db7532] [PAY-386] [PAY-387] Created Mobile + Web UIs for First Playlist Challenge (#1565) Reed [0c36c77] [C-667] Fix desktop build on mac (#1564) Raymond Jacobson [ba73747] [C-565] Add chain icon to collectibles card (#1563) Dylan Jeffers [09bb30a] Fix various mobile types (#1562) Dylan Jeffers [85ac517] [PAY-405] Fixed Claim Rewards Pill To Respect Optimizely Config (#1558) Reed [24de5e1] [C-581] Improve probers upload flow a11y (#1561) Dylan Jeffers [3f79f27] [C-575] Fix sentry and dev warnings (#1560) Dylan Jeffers [a533cce] [C-654] Improve web modal usage and performance (#1559) Dylan Jeffers [381cfcc] [C-400] Add logic for mobile app minimum version (#1555) Kyle Shanks [b996975] Upgrade CRA and webpack to v5 (#1508) Dylan Jeffers [981ef8b] [PAY-384] Created First Tip Challenge Mobile UI (#1554) Reed [d271051] Rework CI to use lerna bootstrap and singular npm install (#1553) Raymond Jacobson [0b51b21] v1.1.12 (#1552) Raymond Jacobson [7029175] Move CP of tar file to s3 step (#1550) Raymond Jacobson

Kyle-Shanks requested review from dylanjeffers, nicoback2, raymondjacobson and sliptype July 7, 2022 18:57

pull-request-size Bot added the size/L label Jul 7, 2022

dylanjeffers approved these changes Jul 7, 2022

View reviewed changes

Kyle-Shanks force-pushed the kj-Mobile-min-app-version branch from e21e588 to cfa2931 Compare July 7, 2022 20:48

sliptype approved these changes Jul 8, 2022

View reviewed changes

Kyle-Shanks force-pushed the kj-Mobile-min-app-version branch from cfa2931 to 57fc4c0 Compare July 8, 2022 16:10

[C-400] Add logic for mobile app minimum version

057dc66

Kyle-Shanks force-pushed the kj-Mobile-min-app-version branch from 57fc4c0 to 057dc66 Compare July 8, 2022 17:24

Kyle-Shanks merged commit 381cfcc into main Jul 8, 2022

Kyle-Shanks deleted the kj-Mobile-min-app-version branch July 8, 2022 17:25

AudiusProject deleted a comment from linear Bot Sep 11, 2023

Conversation

Kyle-Shanks commented Jul 7, 2022

Description

Dragons

How Has This Been Tested?

How will this change be monitored?

Feature Flags

Uh oh!

Kyle-Shanks commented Jul 7, 2022

Uh oh!

audius-infra commented Jul 7, 2022

Uh oh!

dylanjeffers left a comment

Choose a reason for hiding this comment

Uh oh!

dylanjeffers Jul 7, 2022

Choose a reason for hiding this comment

Uh oh!

Kyle-Shanks Jul 7, 2022

Choose a reason for hiding this comment

Uh oh!

dylanjeffers Jul 7, 2022

Choose a reason for hiding this comment

Uh oh!

sliptype Jul 8, 2022

Choose a reason for hiding this comment

Uh oh!

Kyle-Shanks Jul 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dylanjeffers Jul 7, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

audius-infra commented Jul 7, 2022

Uh oh!

sliptype left a comment

Choose a reason for hiding this comment

Uh oh!

sliptype Jul 8, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

audius-infra commented Jul 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Kyle-Shanks Jul 8, 2022 •

edited

Loading