Skip to content
This repository was archived by the owner on Oct 4, 2023. It is now read-only.

Fix brave solana integration#1579

Merged
raymondjacobson merged 1 commit into
mainfrom
rj-fix-brave-solana-integration
Jul 12, 2022
Merged

Fix brave solana integration#1579
raymondjacobson merged 1 commit into
mainfrom
rj-fix-brave-solana-integration

Conversation

@raymondjacobson

@raymondjacobson raymondjacobson commented Jul 12, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Fixes integration with Brave browser on solana side. Brave does not let you invoke signMessage as a pure function, it must be called on the solana object itself.

Error message was:
"Function must be called on an object of type JSSolanaProvider"

Dragons

Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Locally with brave. Connecting wallet now works.

How will this change be monitored?

For features that are critical or could fail silently please describe the monitoring/alerting being added.

Feature Flags

Are all new features properly feature flagged? Describe added feature flags.

@raymondjacobson raymondjacobson changed the title Rj fix brave solana integration Fix brave solana integration Jul 12, 2022
dylanjeffers
dylanjeffers approved these changes Jul 12, 2022
View reviewed changes

@dylanjeffers dylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

Comment thread packages/web/src/store/token-dashboard/sagas.ts
function* connectSPLWallet(
connectingWallet: string,
solanaSignMessage: SolanaSignMessage,
solana: any,

@dylanjeffers dylanjeffers Jul 12, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we got anything for this? no Solana type from some lib?

@raymondjacobson raymondjacobson Jul 12, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already any all over the file, so maybe we can address separately

@audius-infra

audius-infra commented Jul 12, 2022

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/rj-fix-brave-solana-integration

@raymondjacobson raymondjacobson merged commit 29f97db into main Jul 12, 2022
@raymondjacobson raymondjacobson deleted the rj-fix-brave-solana-integration branch July 12, 2022 21:37
audius-infra pushed a commit that referenced this pull request Jul 16, 2022
v1.1.13
d6215f1 
[a326ed1] [PAY-425] Fix optimistic trophy icon for supporting (#1586) Marcus Pasell
[f760497] Remove antd table shadow pseudoelements (#1604) Kyle Shanks
[6caebfb] Change WRITE_QUORUM_ENABLED to session flag (#1602) Theo Ilie
[81837c8] Add shimmer effect to skeleton component (#1583) Kyle Shanks
[91d638c] Update explore endpoints in libs to use v1 (#1539) Joseph Lee
[bc5a32e] Change logout from sync to async due to SDK changes (#1567) nicoback2
[9ff7510] [PAY-432] Freeze balance briefly after sending a tip (#1599) Michael Piazza
[3620262] Add main role (#1597) Sebastian Klingler
[5ec991f] [PAY-422] Fix tip icon notification matrix color (#1594) Dylan Jeffers
[6523977] [C-677] Fix profile-screen icon hit-slop and color (#1595) Dylan Jeffers
[3265713] [C-679] Fix Probers (#1591) Sebastian Klingler
[0493d99] [PAY-424] Remove search icon in user-lists (#1596) Dylan Jeffers
[68d4ac4] [PAY-423] Fix matrix-mode send-tip web styles (#1593) Dylan Jeffers
[fd39136] [PAY-426] Fix native large button icon sizing/spacing (#1592) Dylan Jeffers
[b874da7] Limit prod mobile builds to main & release branches (#1590) Sebastian Klingler
[462e032] [PAY-393] Fix active state animation on mobile SupportingTile (#1587) Michael Piazza
[1f59819] [C-664] Add @audius/common (#1584) Dylan Jeffers
[56e2a41] [C-427] Fix matrix mode color for dismiss feed-tip-tile button (#1588) Dylan Jeffers
[8b74c18] Fix entity and solana types in web (#1585) Dylan Jeffers
[3301e27] Fix sdk lazyload and upgrade to sdk 0.0.12 (#1581) Sebastian Klingler
[c91f722] [CON-234] Add write quorum feature flag (#1576) Theo Ilie
[e7dc144] Fix native milestone notification (#1575) Dylan Jeffers
[9af0e95] [PAY-399] Fix reaction notification selection bug (#1573) Dylan Jeffers
[13db0db] [C-674] Upgrade eslint, prettier, and plugins to latest (#1578) Dylan Jeffers
[0285c7e] [PAY-414] Fix unsending reactions (#1582) Michael Piazza
[dee8c96] Fix solana phantom provider types (#1580) Raymond Jacobson
[29f97db] Fix solana sign message for Brave (#1579) Raymond Jacobson
[6848f81] [PAY-415] Clicking tipping notifications goes to profile (#1574) Dylan Jeffers
[ae44d1c] [C-409] Add eslint-config-audius, use in packages (#1570) Dylan Jeffers
[8e39c2c] Fix sign-on action types (#1571) Dylan Jeffers
[c3fb7f9] Remove extra lint step (#1572) Sebastian Klingler
[ca26a53] Add ssh key for audius-infra write access (#1569) Sebastian Klingler
[71fe7a8] [C-402] Add min version logic for the desktop app (#1568) Kyle Shanks
[068c2f4] Fix jitter (#1566) Saliou Diallo
[6db7532] [PAY-386] [PAY-387] Created Mobile + Web UIs for First Playlist Challenge (#1565) Reed
[0c36c77] [C-667] Fix desktop build on mac (#1564) Raymond Jacobson
[ba73747] [C-565] Add chain icon to collectibles card (#1563) Dylan Jeffers
[09bb30a] Fix various mobile types (#1562) Dylan Jeffers
[85ac517] [PAY-405] Fixed Claim Rewards Pill To Respect Optimizely Config (#1558) Reed
[24de5e1] [C-581] Improve probers upload flow a11y (#1561) Dylan Jeffers
[3f79f27] [C-575] Fix sentry and dev warnings (#1560) Dylan Jeffers
[a533cce] [C-654] Improve web modal usage and performance (#1559) Dylan Jeffers
[381cfcc] [C-400] Add logic for mobile app minimum version (#1555) Kyle Shanks
[b996975] Upgrade CRA and webpack to v5 (#1508) Dylan Jeffers
[981ef8b] [PAY-384] Created First Tip Challenge Mobile UI (#1554) Reed
[d271051] Rework CI to use lerna bootstrap and singular npm install (#1553) Raymond Jacobson
[0b51b21] v1.1.12 (#1552) Raymond Jacobson
[7029175] Move CP of tar file to s3 step (#1550) Raymond Jacobson
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sliptype sliptype Awaiting requested review from sliptype

1 more reviewer

@dylanjeffers dylanjeffers dylanjeffers approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@raymondjacobson @audius-infra @dylanjeffers