[ET-VK] Store unique ptr to StagingBuffer and SymInt in Value instead of inlined object, to reduce Value struct size from 80 to 32 bytes.#7152
Merged
facebook-github-bot merged 6 commits intogh/trivedivivek/18/basefrom Dec 9, 2024
Conversation
… of inlined object, to reduce Value struct size from 80 to 32 bytes. This diff aims to reduce the size of the `Value` struct from 80 bytes to 32 bytes by storing a unique pointer to `StagingBuffer` and `SymInt` instead of inlining the objects. Differential Revision: [D66677759](https://our.internmc.facebook.com/intern/diff/D66677759/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7152
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8b96c81 with merge base b9db0a3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Dec 2, 2024
Merged
trviv
added a commit
that referenced
this pull request
Dec 2, 2024
… of inlined object, to reduce Value struct size from 80 to 32 bytes. This diff aims to reduce the size of the `Value` struct from 80 bytes to 32 bytes by storing a unique pointer to `StagingBuffer` and `SymInt` instead of inlining the objects. Differential Revision: [D66677759](https://our.internmc.facebook.com/intern/diff/D66677759/) ghstack-source-id: 256135680 Pull Request resolved: #7152
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66677759 |
…lue instead of inlined object, to reduce Value struct size from 80 to 32 bytes." This diff aims to reduce the size of the `Value` struct from 80 bytes to 32 bytes by storing a unique pointer to `StagingBuffer` and `SymInt` instead of inlining the objects. Differential Revision: [D66677759](https://our.internmc.facebook.com/intern/diff/D66677759/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66677759 |
trviv
added a commit
that referenced
this pull request
Dec 4, 2024
… of inlined object, to reduce Value struct size from 80 to 32 bytes. Pull Request resolved: #7152 This diff aims to reduce the size of the `Value` struct from 80 bytes to 32 bytes by storing a unique pointer to `StagingBuffer` and `SymInt` instead of inlining the objects. ghstack-source-id: 256271410 @exported-using-ghexport Differential Revision: [D66677759](https://our.internmc.facebook.com/intern/diff/D66677759/)
…lue instead of inlined object, to reduce Value struct size from 80 to 32 bytes." This diff aims to reduce the size of the `Value` struct from 80 bytes to 32 bytes by storing a unique pointer to `StagingBuffer` and `SymInt` instead of inlining the objects. Differential Revision: [D66677759](https://our.internmc.facebook.com/intern/diff/D66677759/) [ghstack-poisoned]
trviv
added a commit
that referenced
this pull request
Dec 5, 2024
… of inlined object, to reduce Value struct size from 80 to 32 bytes. Pull Request resolved: #7152 This diff aims to reduce the size of the `Value` struct from 80 bytes to 32 bytes by storing a unique pointer to `StagingBuffer` and `SymInt` instead of inlining the objects. ghstack-source-id: 256643643 @exported-using-ghexport Differential Revision: [D66677759](https://our.internmc.facebook.com/intern/diff/D66677759/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66677759 |
…lue instead of inlined object, to reduce Value struct size from 80 to 32 bytes." This diff aims to reduce the size of the `Value` struct from 80 bytes to 32 bytes by storing a unique pointer to `StagingBuffer` and `SymInt` instead of inlining the objects. Differential Revision: [D66677759](https://our.internmc.facebook.com/intern/diff/D66677759/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66677759 |
This was referenced Dec 6, 2024
Merged
SS-JIA
approved these changes
Dec 6, 2024
This was referenced Dec 6, 2024
…lue instead of inlined object, to reduce Value struct size from 80 to 32 bytes." This diff aims to reduce the size of the `Value` struct from 80 bytes to 32 bytes by storing a unique pointer to `StagingBuffer` and `SymInt` instead of inlining the objects. Differential Revision: [D66677759](https://our.internmc.facebook.com/intern/diff/D66677759/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66677759 |
…lue instead of inlined object, to reduce Value struct size from 80 to 32 bytes." This diff aims to reduce the size of the `Value` struct from 80 bytes to 32 bytes by storing a unique pointer to `StagingBuffer` and `SymInt` instead of inlining the objects. Differential Revision: [D66677759](https://our.internmc.facebook.com/intern/diff/D66677759/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66677759 |
kirklandsign
pushed a commit
that referenced
this pull request
Dec 10, 2024
… of inlined object, to reduce Value struct size from 80 to 32 bytes. Pull Request resolved: #7152 This diff aims to reduce the size of the `Value` struct from 80 bytes to 32 bytes by storing a unique pointer to `StagingBuffer` and `SymInt` instead of inlining the objects. ghstack-source-id: 257227239 @exported-using-ghexport Differential Revision: [D66677759](https://our.internmc.facebook.com/intern/diff/D66677759/) Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff aims to reduce the size of the
Valuestruct from 80 bytes to 32 bytes by storing a unique pointer toStagingBufferandSymIntinstead of inlining the objects.Differential Revision: D66677759