[ET-VK] Replacing use of adaptive_work_group_size function by create_local_wg_size function.#7016
Merged
facebook-github-bot merged 7 commits intogh/trivedivivek/15/basefrom Dec 5, 2024
Conversation
…local_wg_size function. This diff replaces the use of the adaptive_work_group_size function with create_local_wg_size function, which is better tuned for improving shader performance. Differential Revision: [D66308779](https://our.internmc.facebook.com/intern/diff/D66308779/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7016
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bdb8eb3 with merge base a04a87f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 21, 2024
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66308779 |
trviv
added a commit
that referenced
this pull request
Nov 21, 2024
…local_wg_size function. This diff replaces the use of the adaptive_work_group_size function with create_local_wg_size function, which is better tuned for improving shader performance. Differential Revision: [D66308779](https://our.internmc.facebook.com/intern/diff/D66308779/) ghstack-source-id: 254810725 Pull Request resolved: #7016
… by create_local_wg_size function." This diff replaces the use of the adaptive_work_group_size function with create_local_wg_size function, which is better tuned for improving shader performance. Differential Revision: [D66308779](https://our.internmc.facebook.com/intern/diff/D66308779/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66308779 |
trviv
added a commit
that referenced
this pull request
Nov 27, 2024
…local_wg_size function for slice and copy ops. Pull Request resolved: #7016 This diff replaces the use of the adaptive_work_group_size function with create_local_wg_size function for slice and copy ops, which is better tuned for improving shader performance. ghstack-source-id: 255606710 @exported-using-ghexport Differential Revision: [D66308779](https://our.internmc.facebook.com/intern/diff/D66308779/)
nathanaelsee
approved these changes
Nov 28, 2024
… by create_local_wg_size function." This diff replaces the use of the adaptive_work_group_size function with create_local_wg_size function, which is better tuned for improving shader performance. Differential Revision: [D66308779](https://our.internmc.facebook.com/intern/diff/D66308779/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66308779 |
trviv
added a commit
that referenced
this pull request
Dec 2, 2024
…local_wg_size function for slice and copy ops. Pull Request resolved: #7016 This diff replaces the use of the adaptive_work_group_size function with create_local_wg_size function for slice and copy ops, which is better tuned for improving shader performance. ghstack-source-id: 255708436 @exported-using-ghexport Differential Revision: [D66308779](https://our.internmc.facebook.com/intern/diff/D66308779/)
… by create_local_wg_size function." This diff replaces the use of the adaptive_work_group_size function with create_local_wg_size function, which is better tuned for improving shader performance. Differential Revision: [D66308779](https://our.internmc.facebook.com/intern/diff/D66308779/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66308779 |
… by create_local_wg_size function." This diff replaces the use of the adaptive_work_group_size function with create_local_wg_size function, which is better tuned for improving shader performance. Differential Revision: [D66308779](https://our.internmc.facebook.com/intern/diff/D66308779/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66308779 |
… by create_local_wg_size function." This diff replaces the use of the adaptive_work_group_size function with create_local_wg_size function, which is better tuned for improving shader performance. Differential Revision: [D66308779](https://our.internmc.facebook.com/intern/diff/D66308779/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66308779 |
… by create_local_wg_size function." This diff replaces the use of the adaptive_work_group_size function with create_local_wg_size function, which is better tuned for improving shader performance. Differential Revision: [D66308779](https://our.internmc.facebook.com/intern/diff/D66308779/) [ghstack-poisoned]
trviv
added a commit
that referenced
this pull request
Dec 5, 2024
…local_wg_size function for slice and copy ops. Pull Request resolved: #7016 This diff replaces the use of the adaptive_work_group_size function with create_local_wg_size function for slice and copy ops, which is better tuned for improving shader performance. ghstack-source-id: 256728327 @exported-using-ghexport Differential Revision: [D66308779](https://our.internmc.facebook.com/intern/diff/D66308779/)
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66308779 |
kirklandsign
pushed a commit
that referenced
this pull request
Dec 5, 2024
…local_wg_size function. Pull Request resolved: #7016 This diff replaces the use of the adaptive_work_group_size function with create_local_wg_size function for slice and copy ops, which is better tuned for improving shader performance. ghstack-source-id: 256728327 @exported-using-ghexport Differential Revision: [D66308779](https://our.internmc.facebook.com/intern/diff/D66308779/) --------- Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff replaces the use of the adaptive_work_group_size function with create_local_wg_size function, which is better tuned for improving shader performance.
Differential Revision: D66308779