[ET-VK] Adding UniformData struct in vTensor class to store uniform data, which will be stored using shared ptr and can be shared with push constants.#7222
Merged
facebook-github-bot merged 4 commits intogh/trivedivivek/21/basefrom Dec 9, 2024
Conversation
…ata, which will be stored using shared ptr and can be shared with push constants. This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7222
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8cf16cb with merge base b9db0a3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66733611 |
This was referenced Dec 6, 2024
Merged
SS-JIA
approved these changes
Dec 6, 2024
This was referenced Dec 6, 2024
…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66733611 |
…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66733611 |
…e uniform data, which will be stored using shared ptr and can be shared with push constants." This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66733611 |
kirklandsign
pushed a commit
that referenced
this pull request
Dec 10, 2024
…ata, which will be stored using shared ptr and can be shared with push constants. Pull Request resolved: #7222 This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. ghstack-source-id: 257227242 @exported-using-ghexport Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/)
kirklandsign
pushed a commit
that referenced
this pull request
Dec 10, 2024
…ata, which will be stored using shared ptr and can be shared with push constants. Pull Request resolved: #7222 This diff adds a new struct called `UniformData` in the `vTensor` class to store uniform data, which can be shared with push constants. The `UniformData` struct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor. Diff adds `Attribute` enum to Tensor class to enumerate attributes supplied to dispatch and `UniformData` class to store tensor data supplied as uniforms to op shaders. The diff also adds write_attribute function to UniformData class to write attribute data to a given memory. ghstack-source-id: 257227242 @exported-using-ghexport Differential Revision: [D66733611](https://our.internmc.facebook.com/intern/diff/D66733611/) Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff adds a new struct called
UniformDatain thevTensorclass to store uniform data, which can be shared with push constants. TheUniformDatastruct contains the sizes, strides, and logical limits of the tensor, as well as the number of elements in the tensor.Diff adds
Attributeenum to Tensor class to enumerate attributes supplied to dispatch andUniformDataclass to store tensor data supplied as uniforms to op shaders.The diff also adds write_attribute function to UniformData class to write attribute data to a given memory.
Differential Revision: D66733611