[ET-VK] Removing unnecessary and redundant members from StagingBuffer.#7220
Merged
facebook-github-bot merged 4 commits intogh/trivedivivek/19/basefrom Dec 9, 2024
Merged
Conversation
This diff removes unnecessary and redundant members from the StagingBuffer class in the Vulkan runtime API. Specifically, the `numel_` and `nbytes_` members are removed, as they can be calculated from the `dtype_` member. This simplifies the class and reduces the amount of memory used. Differential Revision: [D66742613](https://our.internmc.facebook.com/intern/diff/D66742613/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7220
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2f406ca with merge base b9db0a3 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66742613 |
This was referenced Dec 6, 2024
Merged
SS-JIA
approved these changes
Dec 6, 2024
This was referenced Dec 6, 2024
…agingBuffer." This diff removes unnecessary and redundant members from the StagingBuffer class in the Vulkan runtime API. Specifically, the `numel_` and `nbytes_` members are removed, as they can be calculated from the `dtype_` member. This simplifies the class and reduces the amount of memory used. Differential Revision: [D66742613](https://our.internmc.facebook.com/intern/diff/D66742613/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66742613 |
…agingBuffer." This diff removes unnecessary and redundant members from the StagingBuffer class in the Vulkan runtime API. Specifically, the `numel_` and `nbytes_` members are removed, as they can be calculated from the `dtype_` member. This simplifies the class and reduces the amount of memory used. Differential Revision: [D66742613](https://our.internmc.facebook.com/intern/diff/D66742613/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66742613 |
…agingBuffer." This diff removes unnecessary and redundant members from the StagingBuffer class in the Vulkan runtime API. Specifically, the `numel_` and `nbytes_` members are removed, as they can be calculated from the `dtype_` member. This simplifies the class and reduces the amount of memory used. Differential Revision: [D66742613](https://our.internmc.facebook.com/intern/diff/D66742613/) [ghstack-poisoned]
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66742613 |
kirklandsign
pushed a commit
that referenced
this pull request
Dec 10, 2024
Pull Request resolved: #7220 This diff removes unnecessary and redundant members from the StagingBuffer class in the Vulkan runtime API. Specifically, the `numel_` and `nbytes_` members are removed, as they can be calculated from the `dtype_` member. This simplifies the class and reduces the amount of memory used. ghstack-source-id: 257227238 @exported-using-ghexport Differential Revision: [D66742613](https://our.internmc.facebook.com/intern/diff/D66742613/)
kirklandsign
pushed a commit
that referenced
this pull request
Dec 10, 2024
Pull Request resolved: #7220 This diff removes unnecessary and redundant members from the StagingBuffer class in the Vulkan runtime API. Specifically, the `numel_` and `nbytes_` members are removed, as they can be calculated from the `dtype_` member. This simplifies the class and reduces the amount of memory used. ghstack-source-id: 257227238 @exported-using-ghexport Differential Revision: [D66742613](https://our.internmc.facebook.com/intern/diff/D66742613/) Co-authored-by: Vivek Trivedi <5340687+trivedivivek@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff removes unnecessary and redundant members from the StagingBuffer class in the Vulkan runtime API. Specifically, the
numel_andnbytes_members are removed, as they can be calculated from thedtype_member. This simplifies the class and reduces the amount of memory used.Differential Revision: D66742613