Port to preCICE v2.0#71
Merged
Merged
Conversation
Recent versions of OpenFOAM require pcorrFinal to also be set in fvSolution. Tested with OpenFOAM 5 (oldest supported) and OpenFOAM v1912 (latest).
If it is not present, deal.II complains. We also provide a (non-empty) output directory in the cylinderFlap_2D tutorial. [ci skip]
BenjaminRodenberg
approved these changes
Feb 12, 2020
Contributor
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
I found one minor thing. Rest looks good.
Co-Authored-By: Benjamin Rüth <benjamin.rueth@tum.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates master with all the changes related to preCICE v2.0.
For more details, see #58, #60, #63, #67, #68.
I also created the tag https://github.com/precice/tutorials/tree/precice-v1.6 for anyone looking for the older tutorials.
Reviewer: Just check the basic meta-information (branches, last commit).