Skip to content

Update tutorials according to major config changes#60

Merged
MakisH merged 13 commits into
precice:developfrom
uekerman:simplify-parallel-config
Jan 10, 2020
Merged

Update tutorials according to major config changes#60
MakisH merged 13 commits into
precice:developfrom
uekerman:simplify-parallel-config

Conversation

@uekerman
Copy link
Copy Markdown
Member

@uekerman uekerman commented Dec 18, 2019 •
edited
Loading

@uekerman uekerman requested a review from MakisH December 18, 2019 12:55
@MakisH MakisH mentioned this pull request Dec 19, 2019
Merged
MakisH
MakisH reviewed Dec 19, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid any confusion, please note that this PR also changes post-processing to acceleration, which is independent of the respective preCICE PR.

@uekerman uekerman changed the title Update tutorials according to "simplify parallel config" Update tutorials according to major config changes Dec 20, 2019
@fsimonis fsimonis mentioned this pull request Dec 20, 2019
Closed
@uekerman uekerman marked this pull request as ready for review December 20, 2019 15:51
@uekerman uekerman mentioned this pull request Jan 8, 2020
Closed
BenjaminRodenberg added a commit to BenjaminRodenberg/systemtests that referenced this pull request Jan 8, 2020
@BenjaminRodenberg
Test against proposed changes in precice/tutorials#60
6d9279d
@BenjaminRodenberg BenjaminRodenberg mentioned this pull request Jan 8, 2020
Closed
@Eder-K Eder-K mentioned this pull request Jan 9, 2020
Merged
28 tasks
@BenjaminRodenberg
Copy link
Copy Markdown
Contributor

BenjaminRodenberg commented Jan 9, 2020

Is this PR ready for merge? There are quite some dependencies on this PR, but I am hesitant to merge, since I am unsure about the state of the review.

@MakisH
Copy link
Copy Markdown
Member

MakisH commented Jan 9, 2020

Is this PR ready for merge? There are quite some dependencies on this PR, but I am hesitant to merge, since I am unsure about the state of the review.

No, it has a few issues, I will fix them as soon as possible.

@MakisH MakisH merged commit 00bd4a8 into precice:develop Jan 10, 2020
@MakisH
Copy link
Copy Markdown
Member

MakisH commented Jan 10, 2020

There were a few relics of precice-config_serial.xml and precice-config_parallel.xml, with a few references in 1-2 scripts. I went through all the directories and scripts and ran all the cases I could quickly run.

I am sorry for the direct merge, somehow I could not manage to push to the fork branch first.

@Eder-K Eder-K mentioned this pull request Jan 12, 2020
Merged
@MakisH MakisH mentioned this pull request Feb 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MakisH MakisH MakisH left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@uekerman @BenjaminRodenberg @MakisH