Skip to content

Remove extrapolation#55

Merged
BenjaminRodenberg merged 2 commits into
precice:developfrom
uekerman:remove-extrapolation
Dec 18, 2019
Merged

Remove extrapolation#55
BenjaminRodenberg merged 2 commits into
precice:developfrom
uekerman:remove-extrapolation

Conversation

@uekerman
Copy link
Copy Markdown
Member

Using an extrapolation for implicit coupling has no guaranteed benefit. Sometimes it gives better results, sometimes not. I would not advise beginners to use it. That's why I suggest to remove it from all tutorials.

Please note This might break the system tests as the results now might differ.

@reviewers: What do you think? How big is the pain to update the reference results for all system tests?

<m2n:sockets from="Calculix1" to="Calculix2" exchange-directory="../" distribution-type="gather-scatter"/>

<coupling-scheme:parallel-implicit>
<!-- <coupling-scheme:parallel-explicit>-->
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was kind of intentionally left here, so that one can easily see what the differences between explicit and implicit are (and aitken vs IQN). But I see that this is inconsistent and dead code, which could eventually lead to trouble.

Copy link
Copy Markdown
Member

@MakisH MakisH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the idea of making the tutorials less scary.

Updating the system tests reference results would be easy, but I would also like @Eder-K's opinion on that.

The most tedious step would be to manually check all the results that changed if they still are physical and close to the (potentially validated) previous results. But it's ok if the tutorials are not completely accurate: the purpose is to learn how to use preCICE.

@Eder-K
Copy link
Copy Markdown

Eder-K commented Nov 15, 2019

I agree with @MakisH in that it should be easy but a little tedious. I will check how the results are altered using this version.

@fsimonis fsimonis changed the base branch from master to develop November 27, 2019 11:05
@BenjaminRodenberg BenjaminRodenberg merged commit 0fdbba2 into precice:develop Dec 18, 2019
@BenjaminRodenberg
Copy link
Copy Markdown
Contributor

In case our systemtests now go crazy: this is good, because we want to get rid of the extrapolation and then we will know where action is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants