Moving configure call into interface initialization#13
Merged
Conversation
BenjaminRodenberg
suggested changes
Jan 14, 2020
Contributor
BenjaminRodenberg
left a comment
There was a problem hiding this comment.
We will also have to update all the tests, before we can merge this PR. See precice/precice#366 (comment)
BenjaminRodenberg
approved these changes
Jan 15, 2020
BenjaminRodenberg
pushed a commit
to precice/precice
that referenced
this pull request
Jan 15, 2020
* Update solverdummy following interface change from precice/python-bindings#13
BenjaminRodenberg
added a commit
that referenced
this pull request
Jan 16, 2020
BenjaminRodenberg
added a commit
to precice/fenics-adapter
that referenced
this pull request
Jan 16, 2020
BenjaminRodenberg
added a commit
to precice/tutorials
that referenced
this pull request
Jan 16, 2020
fsimonis
pushed a commit
to fsimonis/precice
that referenced
this pull request
Jan 27, 2020
* Update solverdummy following interface change from precice/python-bindings#13
BenjaminRodenberg
added a commit
to precice/fenics-adapter
that referenced
this pull request
Feb 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With reference to precice/precice#366, the configuration call is transferred into the interface initialization call
Closes #11