connectors: own app metadata types - #29723
Merged
Merged
Conversation
This was referenced Jun 23, 2026
anp-oai
force-pushed
the
codex/split-connector-metadata-types
branch
from
June 23, 2026 21:50
413735a to
e7d1ade
Compare
anp-oai
force-pushed
the
codex/split-config-layer-types
branch
2 times, most recently
from
June 23, 2026 22:03
61f5258 to
015c659
Compare
anp-oai
force-pushed
the
codex/split-connector-metadata-types
branch
from
June 23, 2026 22:03
e7d1ade to
4cb1d64
Compare
anp-oai
force-pushed
the
codex/split-config-layer-types
branch
from
June 23, 2026 22:21
015c659 to
ed61b3f
Compare
anp-oai
force-pushed
the
codex/split-connector-metadata-types
branch
from
June 23, 2026 22:21
4cb1d64 to
5a0f9bc
Compare
anp-oai
force-pushed
the
codex/split-config-layer-types
branch
from
June 23, 2026 22:53
ed61b3f to
1e52f8f
Compare
anp-oai
force-pushed
the
codex/split-connector-metadata-types
branch
from
June 23, 2026 22:53
5a0f9bc to
2e70d14
Compare
anp-oai
force-pushed
the
codex/split-config-layer-types
branch
from
June 23, 2026 23:35
1e52f8f to
a73bfc8
Compare
anp-oai
force-pushed
the
codex/split-connector-metadata-types
branch
from
June 23, 2026 23:35
2e70d14 to
9e030cd
Compare
anp-oai
commented
Jun 24, 2026
anp-oai
commented
Jun 24, 2026
anp-oai
force-pushed
the
codex/split-config-layer-types
branch
from
June 24, 2026 00:30
a73bfc8 to
f093c8f
Compare
anp-oai
force-pushed
the
codex/split-connector-metadata-types
branch
from
June 24, 2026 00:30
9e030cd to
0a365db
Compare
anp-oai
force-pushed
the
codex/split-config-layer-types
branch
from
June 24, 2026 00:46
f093c8f to
e70d4aa
Compare
anp-oai
force-pushed
the
codex/split-connector-metadata-types
branch
from
June 24, 2026 00:46
0a365db to
5a3489e
Compare
anp-oai
marked this pull request as ready for review
June 24, 2026 01:10
Contributor
Author
|
@codex review |
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5a3489e148
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
anp-oai
force-pushed
the
codex/split-config-layer-types
branch
from
June 24, 2026 03:12
e70d4aa to
80ed159
Compare
anp-oai
force-pushed
the
codex/split-connector-metadata-types
branch
from
June 24, 2026 03:12
5a3489e to
d0bf022
Compare
anp-oai
force-pushed
the
codex/split-config-layer-types
branch
from
June 24, 2026 03:42
80ed159 to
3942ea3
Compare
sayan-oai
approved these changes
Jun 24, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 24, 2026
## Why Config layer provenance describes how effective configuration was assembled, so it belongs with the config loader rather than in app-server's serialized API types. ## What changed - Moved `ConfigLayerSource`, `ConfigLayerMetadata`, and `ConfigLayer` ownership into `codex-config`. - Kept app-server's wire payloads unchanged and added explicit conversions at the app boundary. - Removed lower-level app-server-protocol dependencies from config consumers. ## Stack This is PR 3 of 6, stacked on [PR #29721](#29721). Review only the delta from `codex/split-auth-domain-types`. Next: [PR #29723](#29723). ## Validation - `codex-config` coverage passed. - App-server config-manager and config RPC coverage passed.
anp-oai
force-pushed
the
codex/split-connector-metadata-types
branch
from
June 24, 2026 04:05
d0bf022 to
89258ea
Compare
anp-oai
enabled auto-merge (squash)
June 24, 2026 04:08
anp-oai
disabled auto-merge
June 24, 2026 04:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Connector metadata is consumed by connector discovery, ChatGPT integration, core, and TUI code. Treating app-server's wire DTO as the shared domain model reverses the intended dependency direction.
What changed
Stack
This is PR 4 of 6, stacked on PR #29722. Review only the delta from
codex/split-config-layer-types. Next: PR #29724.Validation