config: own layer provenance types - #29722
Merged
Merged
Conversation
This was referenced Jun 23, 2026
anp-oai
force-pushed
the
codex/split-config-layer-types
branch
from
June 23, 2026 21:50
c7ae534 to
61f5258
Compare
anp-oai
force-pushed
the
codex/split-auth-domain-types
branch
2 times, most recently
from
June 23, 2026 22:03
f00f809 to
64120ff
Compare
anp-oai
force-pushed
the
codex/split-config-layer-types
branch
from
June 23, 2026 22:03
61f5258 to
015c659
Compare
anp-oai
force-pushed
the
codex/split-auth-domain-types
branch
from
June 23, 2026 22:20
64120ff to
76d09e4
Compare
anp-oai
force-pushed
the
codex/split-config-layer-types
branch
from
June 23, 2026 22:21
015c659 to
ed61b3f
Compare
anp-oai
force-pushed
the
codex/split-auth-domain-types
branch
from
June 23, 2026 22:53
76d09e4 to
8b382e2
Compare
anp-oai
force-pushed
the
codex/split-config-layer-types
branch
from
June 23, 2026 22:53
ed61b3f to
1e52f8f
Compare
anp-oai
force-pushed
the
codex/split-auth-domain-types
branch
from
June 23, 2026 23:35
8b382e2 to
d7542b0
Compare
anp-oai
force-pushed
the
codex/split-config-layer-types
branch
from
June 23, 2026 23:35
1e52f8f to
a73bfc8
Compare
anp-oai
commented
Jun 24, 2026
anp-oai
force-pushed
the
codex/split-auth-domain-types
branch
from
June 24, 2026 00:30
d7542b0 to
d9cced7
Compare
anp-oai
force-pushed
the
codex/split-config-layer-types
branch
from
June 24, 2026 00:30
a73bfc8 to
f093c8f
Compare
anp-oai
force-pushed
the
codex/split-auth-domain-types
branch
from
June 24, 2026 00:46
d9cced7 to
80adf1c
Compare
anp-oai
force-pushed
the
codex/split-config-layer-types
branch
from
June 24, 2026 00:46
f093c8f to
e70d4aa
Compare
anp-oai
marked this pull request as ready for review
June 24, 2026 01:03
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
sayan-oai
approved these changes
Jun 24, 2026
anp-oai
force-pushed
the
codex/split-auth-domain-types
branch
from
June 24, 2026 02:53
80adf1c to
0690561
Compare
anp-oai
added a commit
that referenced
this pull request
Jun 24, 2026
## Why Authentication mode is a domain concept used by login, model selection, telemetry, and transports. Keeping the canonical type in app-server protocol forces those lower-level crates to depend on an unrelated wire API. ## What changed - Added canonical `codex_protocol::auth::AuthMode` domain values. - Kept the app-server wire DTO unchanged and added an explicit app-side conversion. - Removed production app-server-protocol dependencies from login, model-provider-info, models-manager, and otel call paths. ## Stack This is PR 2 of 6, stacked on [PR #29714](#29714). Review only the delta from `codex/split-json-rpc-protocols`. Next: [PR #29722](#29722). ## Validation - Auth and login coverage passed in the focused protocol/domain test run. - App-server account and auth conversion coverage passed.
anp-oai
force-pushed
the
codex/split-config-layer-types
branch
from
June 24, 2026 03:12
e70d4aa to
80ed159
Compare
anp-oai
force-pushed
the
codex/split-config-layer-types
branch
from
June 24, 2026 03:42
80ed159 to
3942ea3
Compare
anp-oai
enabled auto-merge (squash)
June 24, 2026 03:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Config layer provenance describes how effective configuration was assembled, so it belongs with the config loader rather than in app-server's serialized API types.
What changed
ConfigLayerSource,ConfigLayerMetadata, andConfigLayerownership intocodex-config.Stack
This is PR 3 of 6, stacked on PR #29721. Review only the delta from
codex/split-auth-domain-types. Next: PR #29723.Validation
codex-configcoverage passed.