mcp: keep elicitation requests below app wire types - #29724
Merged
Conversation
This was referenced Jun 23, 2026
anp-oai
force-pushed
the
codex/split-connector-metadata-types
branch
from
June 23, 2026 21:50
413735a to
e7d1ade
Compare
anp-oai
force-pushed
the
codex/split-mcp-elicitation-types
branch
from
June 23, 2026 21:50
1f898bc to
4513560
Compare
anp-oai
force-pushed
the
codex/split-connector-metadata-types
branch
from
June 23, 2026 22:03
e7d1ade to
4cb1d64
Compare
anp-oai
force-pushed
the
codex/split-mcp-elicitation-types
branch
from
June 23, 2026 22:04
4513560 to
1060c61
Compare
anp-oai
force-pushed
the
codex/split-connector-metadata-types
branch
from
June 23, 2026 22:21
4cb1d64 to
5a0f9bc
Compare
anp-oai
force-pushed
the
codex/split-mcp-elicitation-types
branch
from
June 23, 2026 22:21
1060c61 to
477f370
Compare
anp-oai
force-pushed
the
codex/split-connector-metadata-types
branch
from
June 23, 2026 22:53
5a0f9bc to
2e70d14
Compare
anp-oai
force-pushed
the
codex/split-mcp-elicitation-types
branch
from
June 23, 2026 22:53
477f370 to
583cc81
Compare
anp-oai
force-pushed
the
codex/split-connector-metadata-types
branch
from
June 23, 2026 23:35
2e70d14 to
9e030cd
Compare
anp-oai
force-pushed
the
codex/split-mcp-elicitation-types
branch
from
June 23, 2026 23:36
583cc81 to
063c4e1
Compare
anp-oai
force-pushed
the
codex/split-connector-metadata-types
branch
from
June 24, 2026 00:30
9e030cd to
0a365db
Compare
anp-oai
force-pushed
the
codex/split-mcp-elicitation-types
branch
from
June 24, 2026 00:30
063c4e1 to
ef724d0
Compare
anp-oai
force-pushed
the
codex/split-connector-metadata-types
branch
from
June 24, 2026 00:46
0a365db to
5a3489e
Compare
anp-oai
force-pushed
the
codex/split-mcp-elicitation-types
branch
from
June 24, 2026 00:46
ef724d0 to
eb612f1
Compare
anp-oai
force-pushed
the
codex/split-connector-metadata-types
branch
from
June 24, 2026 03:12
5a3489e to
d0bf022
Compare
anp-oai
force-pushed
the
codex/split-mcp-elicitation-types
branch
from
June 24, 2026 03:13
eb612f1 to
2424e1f
Compare
anp-oai
force-pushed
the
codex/split-connector-metadata-types
branch
from
June 24, 2026 04:05
d0bf022 to
89258ea
Compare
anp-oai
force-pushed
the
codex/split-mcp-elicitation-types
branch
from
June 24, 2026 04:06
2424e1f to
3590cf4
Compare
anp-oai
added a commit
that referenced
this pull request
Jun 24, 2026
## Why Connector metadata is consumed by connector discovery, ChatGPT integration, core, and TUI code. Treating app-server's wire DTO as the shared domain model reverses the intended dependency direction. ## What changed - Added connector-owned app branding, review, screenshot, metadata, and info types. - Added explicit conversions in app-server and TUI while preserving app-server's wire payloads. - Removed production app-server-protocol dependencies from connectors and ChatGPT connector code. ## Stack This is PR 4 of 6, stacked on [PR #29722](#29722). Review only the delta from `codex/split-config-layer-types`. Next: [PR #29724](#29724). ## Validation - Connector and tools coverage passed. - App-server app-list coverage passed: 13 tests.
anp-oai
force-pushed
the
codex/split-mcp-elicitation-types
branch
from
June 24, 2026 05:09
3590cf4 to
1550250
Compare
anp-oai
marked this pull request as ready for review
June 24, 2026 05:23
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
anp-oai
force-pushed
the
codex/split-mcp-elicitation-types
branch
from
June 24, 2026 19:00
1550250 to
a8788d4
Compare
Contributor
Author
|
@codex review |
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
sayan-oai
approved these changes
Jun 24, 2026
anp-oai
force-pushed
the
codex/split-mcp-elicitation-types
branch
from
June 24, 2026 20:32
a8788d4 to
4b7cb7b
Compare
anp-oai
enabled auto-merge (squash)
June 24, 2026 20:32
anp-oai
force-pushed
the
codex/split-mcp-elicitation-types
branch
from
June 24, 2026 20:42
4b7cb7b to
88479f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Core and tools need to request MCP elicitation without constructing app-server wire payloads. The request should remain a neutral protocol concept until app-server serializes it for a client.
What changed
codex_protocol::approvals::ElicitationRequest.Stack
This is PR 5 of 6, stacked on PR #29723. Review only the delta from
codex/split-connector-metadata-types. Next: PR #29725.Validation
codex-coreMCP coverage passed: 87 tests.