auth: move domain mode below app wire types - #29721
Merged
Merged
Conversation
This was referenced Jun 23, 2026
anp-oai
force-pushed
the
codex/split-auth-domain-types
branch
from
June 23, 2026 21:50
22ed4a0 to
f00f809
Compare
anp-oai
force-pushed
the
codex/split-json-rpc-protocols
branch
from
June 23, 2026 21:50
71b9384 to
732f3eb
Compare
anp-oai
commented
Jun 23, 2026
anp-oai
force-pushed
the
codex/split-json-rpc-protocols
branch
from
June 23, 2026 22:02
732f3eb to
d8f3fd2
Compare
anp-oai
force-pushed
the
codex/split-auth-domain-types
branch
from
June 23, 2026 22:03
f00f809 to
64120ff
Compare
anp-oai
force-pushed
the
codex/split-json-rpc-protocols
branch
from
June 23, 2026 22:20
d8f3fd2 to
ac409e9
Compare
anp-oai
force-pushed
the
codex/split-auth-domain-types
branch
from
June 23, 2026 22:20
64120ff to
76d09e4
Compare
anp-oai
added a commit
that referenced
this pull request
Jun 23, 2026
## Why The app-server and exec-server expose separate JSON-RPC APIs, but exec-server currently sources its serialized protocol and envelope types through app-server-oriented code. Giving each API an explicit owner makes the crate boundary legible without introducing shared generic envelopes. ## What changed - Added `codex-exec-server-protocol` to own exec DTOs, process IDs, and JSON-RPC envelopes. - Updated exec-server clients, transports, handlers, and tests to use the new crate. - Exposed app-server's existing JSON-RPC types through a public `rpc` module while retaining root re-exports. - Preserved existing wire shapes, including exec `PathUri` behavior. ## Stack This is PR 1 of 6. Next: [PR #29721](#29721), which moves auth mode below the app wire boundary. ## Validation - Exec-server protocol and server coverage passed in the focused protocol test runs. - App-server protocol schema fixtures passed.
anp-oai
force-pushed
the
codex/split-auth-domain-types
branch
from
June 23, 2026 22:53
76d09e4 to
8b382e2
Compare
anp-oai
commented
Jun 23, 2026
anp-oai
force-pushed
the
codex/split-auth-domain-types
branch
from
June 23, 2026 23:35
8b382e2 to
d7542b0
Compare
anp-oai
marked this pull request as ready for review
June 24, 2026 00:10
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
anp-oai
force-pushed
the
codex/split-auth-domain-types
branch
2 times, most recently
from
June 24, 2026 00:46
d9cced7 to
80adf1c
Compare
sayan-oai
approved these changes
Jun 24, 2026
anp-oai
force-pushed
the
codex/split-auth-domain-types
branch
from
June 24, 2026 02:53
80adf1c to
0690561
Compare
anp-oai
enabled auto-merge (squash)
June 24, 2026 02:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Authentication mode is a domain concept used by login, model selection, telemetry, and transports. Keeping the canonical type in app-server protocol forces those lower-level crates to depend on an unrelated wire API.
What changed
codex_protocol::auth::AuthModedomain values.Stack
This is PR 2 of 6, stacked on PR #29714. Review only the delta from
codex/split-json-rpc-protocols. Next: PR #29722.Validation