13.0.0 beta 2

[MorrisJobke]

Anything crucial that should go into the beta 2? Maybe check https://github.com/nextcloud/server/pulls?q=is%3Aopen+is%3Apr+milestone%3A%22Nextcloud+13%22 and then comment here

cc @ChristophWurst @rullzer @schiessle @blizzz @skjnldsv @georgehrke @karlitschek

Requested to get into 13 by owner

• ensure that users are cached when they are retrieved #7418 - cache LDAP users properly to reduce requests
• Fix flow #7115 - fix login flow
• Guest flex instead of absolute #7249 - flex layout in guests.css (login, update, error pages)
• Use apps versions to generate suffix when possible #7244 - css suffix based on app version
• CardDAV convertor check should not be to wide #7342 - CardDAV convertor check should not be to wide
• Fix email buttons for white theme #7427 - fix email button color for white themes
• Create activities for (un)publishing calendar events #6590 - Create activities for (un)publishing calendar events
• Fix the FreeBusy request handling for proper scheduling support #6715 - free/busy handling in calendar
• Parse Sabre Exception in OC.Files.Client and file-upload #6079 - Parse Sabre Exception in OC.Files.Client and file-upload
• Remove avatar on user deletion #6668 - Remove avatar on user deletion
• Catch the errors related to untrusted self signed certificates for federation #7450 - Catch the errors related to untrusted self signed certificates for federation
• App content list fixes #7431 - app content lists fixes
• Make ContactsStore a public API #6637 - Make ContactsStore a public API
• Properly detect if fopen fails for txt previews #7453 - Properly detect if fopen fails for txt previews
• Add confirmation button to share input #7196 - Add confirmation button to share input moved to 14
• Fix unit tests for CalendarManager #7458 - Fix unit tests for CalendarManager
• Opt out of birthday calendar #6884 - Opt out of birthday calendar
• Nextcloud 13 is not compatible with newer than php 7.2 #6830 - Nextcloud 13 is not compatible with newer than php 7.2

Easy to review

• Add api clients for talking to remote clouds #6651 - Add api clients for talking to remote clouds
• Fallback to filename based detection if the remote dav server doesn't… #6682 - Fallback to filename based detection if the remote dav server doesn't know the mime type
• Ensure that X-OC-MTime header is an integer with chunked uploads #7313 - Ensure that X-OC-MTime header is an integer with chunked uploads
• don't create sorter instances when none was requested #7324 - don't create sorter instances when none was requested
• Set autocomplete on share password input #7461 - Set autocomplete on share password input

13, but help needed

• Can not change encryption directory #6805 - Can not change encryption directory (@schiessle) moved to 14

13 or 14?

• Properly decode id from URI #4528 - Properly decode id from URI moved to 14
• Let the admin configure the default share permissions #7363 - Let admin configure default share permissions moved to 14
• Add confirmation button to share input #7196 - Add confirmation button to share input moved to 14
• [uc] Introduce pagination in files-filter report #4530 - Introduce pagination in files-filter report moved to 14

[skjnldsv]

I will push the app content list fix this afternoon! :)

[blizzz]

I'd like to have #7418 and #7321 included. Both small PRs.

[skjnldsv]

Can we include #7249 and #7431 please?

[MorrisJobke]

Can we include #7249 and #7431 please?

Sure - just find somebody who helps with reviewing #7249 because I already did ;)

[MorrisJobke]

I updated the initial post with a list of all PRs that still have the milestone 13 assigned. I would prefer to either get them in or move them to 14 before the beta 2. And afterwards only have pure fixes and also do the branching quite soon. Opinions?

[MorrisJobke]

Also maintainers of apps that are close to the server (e2e, talk, ...) should raise their voice if there is stuff to be merged until the beta2. cc @Ivansss @schiessle

[Ivansss]

I'm not aware of anything that need to merged in server for Talk.
@danxuliu what about mentions in chat? you were discussing something with @blizzz recently about moving something from comments to server.
I'm happy that #6876 is merged so it can be used in Talk mobile apps 😊

[danxuliu]

I'm not aware of anything that need to merged in server for Talk.

Some changes may be needed regarding touch screens and gestures, but the code is not ready yet for Talk so there is no need to delay the beta.

what about mentions in chat? you were discussing something with @blizzz recently about moving something from comments to server.

Not a showstopper for beta 2; it is just a corner case and a minor detail (if Comments app is disabled and Talk is enabled the formatted mentions show the user name instead of the display name).

[MorrisJobke]

• Can not change encryption directory #6805 - Can not change encryption directory (@schiessle)
• [uc] Introduce pagination in files-filter report #4530 - Introduce pagination in files-filter report
• Opt out of birthday calendar #6884 - Opt out of birthday calendar

It looks like those three PRs will not make it to 13 and will be moved to 14. cc @georgehrke @schiessle @icewind1991

I will move them later this evening and have a last look at everything. Thanks to @blizzz and @rullzer for todays review session of all the pending PRs.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@134bd51). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master    #7425   +/-   ##
=========================================
  Coverage          ?   50.43%           
  Complexity        ?    24710           
=========================================
  Files             ?     1522           
  Lines             ?    86416           
  Branches          ?        0           
=========================================
  Hits              ?    43581           
  Misses            ?    42835           
  Partials          ?        0

Impacted Files	Coverage Δ	Complexity Δ
version.php	0% <0%> (ø)	0 <0> (?)

[MorrisJobke]

Rebased to see if CI complains about the beta 2

[rullzer]

CI error seems to be some weird checkout hickup

[MorrisJobke]

Let's do it :)