Nextcloud 13 is not compatible with newer than php 7.2#6830
Nextcloud 13 is not compatible with newer than php 7.2#6830MorrisJobke merged 1 commit intomasterfrom
Conversation
|
There should be more? remote.php? ocs/? |
Codecov Report
@@ Coverage Diff @@
## master #6830 +/- ##
============================================
- Coverage 51.11% 51.11% -0.01%
Complexity 24900 24900
============================================
Files 1600 1601 +1
Lines 94763 94772 +9
Branches 1367 1367
============================================
- Hits 48439 48438 -1
- Misses 46324 46334 +10
|
|
@nickvergessen they include base.php |
Based on what/where we currently check for a min-version, also |
yes @rullzer but I don't see any checking there either? |
If we do that we need to also add a 500 error status code. Otherwise our sync clients may get a 200 and sync down the text error message … 😱 |
|
Well the same happens when there is another language based error? |
|
@rullzer Could you make this a 500 page? |
|
Let's move this to 14 and maybe backport it. |
185b623 to
2fa7a93
Compare
MorrisJobke
left a comment
There was a problem hiding this comment.
Tested and works 👍 It now also serves a 500 status code
|
CI failure should be fixed by #7458 |
|
Lets get this into 13 then. So it is there from the start. |
|
Should also be documented somewhere, docs or release notes, or both |
Already is ;) |
|
Let me rebase - to check if CI is green. |
2fa7a93 to
75b0460
Compare
75b0460 to
7f9c2cf
Compare
Just to avoid users from trying this with a to new (untested) php version * Moved the check logic to 1 place * All directly callable scripts just require this on top * exit hard (-1) so we know scripts won't continue * Return status 500 so no sync clients will try fancy stuff Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
7f9c2cf to
b8af7ee
Compare
|
Failure is due to a connection issue while cloning -> merge |
Easy one.
Just so we don't forget and have people try NC13 with a to new version of php.