ensure that users are cached when they are retrieved#7418
Merged
MorrisJobke merged 2 commits intomasterfrom Dec 11, 2017
Merged
ensure that users are cached when they are retrieved#7418MorrisJobke merged 2 commits intomasterfrom
MorrisJobke merged 2 commits intomasterfrom
Conversation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Codecov Report
@@ Coverage Diff @@
## master #7418 +/- ##
=============================================
- Coverage 50.93% 27.27% -23.66%
- Complexity 24710 24712 +2
=============================================
Files 1586 1522 -64
Lines 94144 86415 -7729
Branches 1364 0 -1364
=============================================
- Hits 47948 23568 -24380
- Misses 46196 62847 +16651
|
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
7310724 to
27f14ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this got lost during the performance changes (sic!), but now comes with a unit test 😊
Basically you see an additional request on LDAP after getting a user list (even on login) that checks for existence of the user. The data is fresh from LDAP however and can be cached right away to avoid this additional requests.
@nextcloud/ldap