Allow cache directory to be configured via config file#11091
Conversation
|
The |
|
We no longer use the command flag but pass it again in the environment. That said, setting it in the config file would be superior. Is there value in doing the same for |
|
Perhaps yes, regarding EMCC_TEMP_DIR. My first question though would be, why would want to set this explicitly like that? Why not rely on the OS-convesion for setting temp dir across all applications? We already default to using |
|
That's a good question. I don't recall. I know that we added this as some of our CI machines kept running out of space in |
|
Yes, I think removing EMCC_TEMP_DIR would be great if we can. |
|
I've updated our build system to no longer use |
| JS_ENGINES = [listify(engine) for engine in JS_ENGINES] | ||
| WASM_ENGINES = [listify(engine) for engine in WASM_ENGINES] | ||
| if not CACHE: | ||
| CACHE = os.path.expanduser(os.path.join('~', '.emscripten_cache')) |
There was a problem hiding this comment.
should we put a default value in tools/settings_template.py?
There was a problem hiding this comment.
No.. we don't normal users to be setting this. Its mostly for the benefit of emsdk. See emscripten-core/emsdk#495.
Right now emsdk has to use the environment variable which I'd like to change.
This is an ancient and untested command line argument. As discussed in #11091 it seems pretty safe for remove. We have `CACHE` config file setting as well as EM_CACHE environment variable.
This is an ancient and (hopefully) unused command line argument. As discussed in #11091 it seems pretty safe for remove. We have `CACHE` config file setting as well as EM_CACHE environment variable to replace it.
This is an ancient and (hopefully) unused command line argument. As discussed in #11091 it seems pretty safe for remove. We have `CACHE` config file setting as well as EM_CACHE environment variable to replace it.
Honor
CACHEsetting in config file as an alternative toEM_CACHEenvironment variable or
--cachecommandline flag.Specifically this is useful for emsdk which wants to set the cache directory
and currently has has to export both EM_CONFIG and EM_CACHE whereas
it should be enough to do just the one.
Hopefully we can remove the command line flag if it has no more
users.