Configure the Emscripten cache directory from the command line.#2816
Merged
kripken merged 1 commit intoOct 11, 2014
Merged
Conversation
Member
|
Looks good, but please add a test for this. Perhaps in tests_other.py, that just runs emcc and sets a different cache dir using this option, and checks that the cache is populated when it needs to be. |
f42faab to
a223291
Compare
This allows passing --cache to emcc to set the Emscripten cache directory rather than only allowing this to be configured via the EM_CACHE environment variable.
Contributor
Author
|
Okay ... this has been updated with that test as requested. |
kripken
added a commit
that referenced
this pull request
Oct 11, 2014
Configure the Emscripten cache directory from the command line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows passing --cache to emcc to set the Emscripten cache
directory rather than only allowing this to be configured via
the EM_CACHE environment variable.