Remove --cache commandline arg#11094
Merged
Merged
Conversation
This is an ancient and (hopefully) unused command line argument. As discussed in #11091 it seems pretty safe for remove. We have `CACHE` config file setting as well as EM_CACHE environment variable to replace it.
kripken
approved these changes
May 7, 2020
sbc100
added a commit
that referenced
this pull request
Apr 28, 2021
This change reverts #13954 and reinstates the `--cache` flag much as it existed prior to #11094. Essentially this change reverts both of those changes. This also allows us to re-enable the test_emar_response_file test for windows. We can look at landing more ubiquitous and robust repsonse file processing that #13954 was aiming at as followup.
sbc100
added a commit
that referenced
this pull request
Apr 28, 2021
This change reverts #13954 and reinstates the `--cache` flag much as it existed prior to #11094. Essentially this change reverts both of those changes. This also allows us to re-enable the test_emar_response_file test for windows. We can look at landing more ubiquitous and robust repsonse file processing that #13954 was aiming at as followup.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 15, 2025
This flag was already removed back in 2020 (emscripten-core#11094) and then restored again in emscripten-core#13954. This change doesn't remove the flag, only deprecates it. Hopefully this was we can give folks plenty of time to stop using it.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 15, 2025
This flag was already removed back in 2020 (emscripten-core#11094) and then restored again in emscripten-core#13954. This change doesn't remove the flag, only deprecates it. Hopefully this was we can give folks plenty of time to stop using it. See emscripten-core#23284
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 15, 2025
This flag was already removed back in 2020 (emscripten-core#11094) and then restored again a year later in emscripten-core#13954. This change doesn't remove the flag, only deprecates it. Hopefully this was we can give folks plenty of time to stop using it. See emscripten-core#23284
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #11091 it seems pretty safe for remove. We have
CACHEconfigfile setting as well as EM_CACHE environment variable.