Conversation
kripken
approved these changes
May 7, 2020
Member
kripken
left a comment
There was a problem hiding this comment.
lgtm aside from the ' stuff that I can't figure out
|
|
||
| if embedded: | ||
| cfg = cfg.replace(emscripten_config_directory, "' + emsdk_path + '") | ||
| cfg = cfg.replace("'" + emscripten_config_directory, "emsdk_path + '") |
Member
There was a problem hiding this comment.
is this intentional? if so, what's going on here?
Collaborator
Author
There was a problem hiding this comment.
Sorry this is general cleanup on the config.
It changes pattern to:
CACHE = emsdk_path + '/.emscripten_cache'
NODE_JS = emsdk_path + '/node/12.9.1_64bit/bin/node'
LLVM_ROOT = emsdk_path + '/fastcomp/fastcomp/bin'
BINARYEN_ROOT = emsdk_path + '/fastcomp'
EMSCRIPTEN_ROOT = emsdk_path + '/fastcomp/emscripten'
EMSCRIPTEN_NATIVE_OPTIMIZER = emsdk_path + '/fastcomp/bin/optimizer'
From the more redundant form:
CACHE = '' + emsdk_path + '/.emscripten_cache'
NODE_JS = '' + emsdk_path + '/node/12.9.1_64bit/bin/node'
LLVM_ROOT = '' + emsdk_path + '/fastcomp/fastcomp/bin'
BINARYEN_ROOT = '' + emsdk_path + '/fastcomp'
EMSCRIPTEN_ROOT = '' + emsdk_path + '/fastcomp/emscripten'
EMSCRIPTEN_NATIVE_OPTIMIZER = '' + emsdk_path + '/fastcomp/bin/optimizer'
sbc100
added a commit
that referenced
this pull request
May 8, 2020
Ooops, I guess even the most innocent-seeming change can have unintended consequences. Switching to embedded by default will at least make this path more tested in the future. Fixed #497
sbc100
added a commit
that referenced
this pull request
May 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See emscripten-core/emscripten#11091