Skip to content

RE1-T119 Build fix#384

Merged
ucswift merged 1 commit into
masterfrom
develop
May 14, 2026
Merged

RE1-T119 Build fix#384
ucswift merged 1 commit into
masterfrom
develop

Conversation

@ucswift
Copy link
Copy Markdown
Member

@ucswift ucswift commented May 14, 2026

Summary by CodeRabbit

  • Chores
    • Enhanced Docker build process to ensure consistent and reliable image creation.

Review Change Stack

@request-info
Copy link
Copy Markdown

request-info Bot commented May 14, 2026

Thanks for opening this, but we'd appreciate a little more information. Could you update it with more details?

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 14, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2baedea4-2b16-47d3-bdda-4953dda2ba79

📥 Commits

Reviewing files that changed from the base of the PR and between 0df76ba and 02ed80e.

📒 Files selected for processing (1)
  • Web/Resgrid.Web.Tts/Dockerfile

📝 Walkthrough

Walkthrough

The Dockerfile for the TTS service now explicitly creates the /usr/local/bin directory in the publish stage before copying ffmpeg and ffprobe binaries into it, ensuring the target directory structure exists.

Changes

FFmpeg binary installation

Layer / File(s) Summary
Directory structure preparation
Web/Resgrid.Web.Tts/Dockerfile
The mkdir -p /usr/local/bin command is added to the publish stage to ensure the target directory exists before copying ffmpeg and ffprobe binaries.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Resgrid/Core#382: Both PRs modify the Web/Resgrid.Web.Tts/Dockerfile publish stage to arrange ffmpeg/ffprobe artifacts under /usr/local.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'RE1-T119 Build fix' references a ticket identifier and uses the vague term 'Build fix' without explaining the specific nature of the Docker build issue being addressed. Replace with a more descriptive title such as 'Create /usr/local/bin directory in Docker build' or 'Fix Docker build by ensuring /usr/local/bin exists' to clarify the specific change.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ucswift
Copy link
Copy Markdown
Member Author

ucswift commented May 14, 2026

Approve

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is approved.

@ucswift ucswift merged commit dbc25b1 into master May 14, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant