Skip to content

RE1-T119 build fix#388

Merged
ucswift merged 1 commit into
masterfrom
develop
May 15, 2026
Merged

RE1-T119 build fix#388
ucswift merged 1 commit into
masterfrom
develop

Conversation

@ucswift
Copy link
Copy Markdown
Member

@ucswift ucswift commented May 15, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Fixed Docker image build process by ensuring required system dependencies and necessary directories are properly initialized during deployment.

Review Change Stack

@request-info
Copy link
Copy Markdown

request-info Bot commented May 15, 2026

Thanks for opening this, but we'd appreciate a little more information. Could you update it with more details?

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ae39afaf-a77e-4982-a60a-e0476c621767

📥 Commits

Reviewing files that changed from the base of the PR and between cf0241c and 80933b3.

📒 Files selected for processing (1)
  • Web/Resgrid.Web.Tts/Dockerfile

📝 Walkthrough

Walkthrough

This PR modifies the TTS Dockerfile to add the passwd OS package dependency and explicitly create the /usr/local/lib directory before installing Piper shared libraries, ensuring the container build has the necessary system dependencies and filesystem structure.

Changes

TTS Container Build Fixes

Layer / File(s) Summary
TTS container dependencies and directory setup
Web/Resgrid.Web.Tts/Dockerfile
Adds passwd package to OS dependencies and creates /usr/local/lib directory to ensure Piper TTS shared libraries can be installed in the publish stage.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • Resgrid/Core#384: Modifies the same Dockerfile publish stage to add missing mkdir -p /usr/local/bin for copying installed binaries.
  • Resgrid/Core#365: Modifies the same Dockerfile to copy libpiper_phonemize.so* into /usr/local/lib and refresh ldconfig.
  • Resgrid/Core#367: Modifies the same Dockerfile apt-get install package list to add missing TTS runtime dependencies.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'RE1-T119 build fix' references a ticket identifier but lacks clarity about the specific build issue being addressed. The changeset involves Docker configuration changes (passwd package and directory creation), but the title does not convey what the actual problem is. Provide a more descriptive title that explains the specific build issue, such as 'Fix Dockerfile build errors by adding passwd package and ensuring directory existence' or similar.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ucswift
Copy link
Copy Markdown
Member Author

ucswift commented May 15, 2026

Approve

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is approved.

@ucswift ucswift merged commit c9d1a0b into master May 15, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant