RE1-T119 Build fix

[ucswift]

Summary by CodeRabbit

• Chores
  • Updated Docker build configuration to streamline the deployment process.

[request-info]

Thanks for opening this, but we'd appreciate a little more information. Could you update it with more details?

[coderabbitai]

Warning

Rate limit exceeded

@ucswift has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 48 minutes and 51 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ab9cdbfc-cddf-45e6-966d-32618bf5b866

📥 Commits

Reviewing files that changed from the base of the PR and between 4f50e97 and 6f6fdf3.

📒 Files selected for processing (1)

• Web/Resgrid.Web.Tts/Dockerfile

📝 Walkthrough

Walkthrough

The Docker build in the publish stage updates its FFmpeg/FFprobe installation to use a static release tarball from johnvansickle.com instead of the BtbN/FFmpeg-Builds GPL release. The installation now discovers and copies binaries dynamically via find rather than relying on a fixed extracted directory path.

Changes

FFmpeg Build Integration

Layer / File(s)	Summary
FFmpeg source and installation method Web/Resgrid.Web.Tts/Dockerfile	FFmpeg/FFprobe installation in the publish stage switches from BtbN/FFmpeg-Builds GPL tarball with fixed extracted paths to johnvansickle.com static tarball with find-based binary discovery and placement into /usr/local/bin.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Resgrid/Core#384: Both PRs modify the same Web/Resgrid.Web.Tts/Dockerfile publish-stage FFmpeg/FFprobe install step by adjusting how those binaries are copied into /usr/local/bin.
• Resgrid/Core#382: Both PRs modify Web/Resgrid.Web.Tts/Dockerfile's publish stage to change how ffmpeg/ffprobe is fetched and placed into the image.
• Resgrid/Core#364: Both PRs modify the same Web/Resgrid.Web.Tts/Dockerfile build steps in the Docker image to change how external FFmpeg/Piper components are downloaded and installed.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'RE1-T119 Build fix' is vague and non-descriptive, using generic terms that don't convey meaningful information about the specific technical changes made to the Dockerfile.	Consider a more descriptive title that highlights the key change, such as 'Update FFmpeg installation method in Docker build' or 'Switch FFmpeg source from BtbN builds to johnvansickle static release'.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch develop

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Web/Resgrid.Web.Tts/Dockerfile`:
- Around line 37-38: Replace the broad find+cp with a deterministic single-match
search that fails if no executable is found: for each binary (ffmpeg, ffprobe)
use a single find invocation that returns the first executable match (e.g. find
/tmp -name 'ffmpeg' -type f -executable -not -path '*/lib/*' -print -quit),
store that path in a shell variable, test that the variable is non-empty, then
cp that single path to /usr/local/bin/ffmpeg (and similarly for ffprobe) and
exit with an error if nothing was found; reference the existing find+cp usage
for ffmpeg and ffprobe in the Dockerfile when implementing this change.
- Around line 34-35: The Dockerfile currently downloads
"https://johnvansickle.com/ffmpeg/releases/ffmpeg-release-amd64-static.tar.xz"
and extracts it without integrity checks; update the build to fetch a trusted
checksum or signature (e.g., the provider's .sha256 or a published SHA256 value)
and verify the downloaded /tmp/ffmpeg.tar.xz before running tar -xf. Concretely:
after the curl that saves /tmp/ffmpeg.tar.xz, download or embed the expected
checksum, validate the archive with sha256sum -c (or verify a detached GPG
signature if available), and if verification fails remove the archive and exit
the build with a non-zero status so the extraction step (tar -xf
/tmp/ffmpeg.tar.xz) only runs when verification passes.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3d965c9f-2b49-472f-a3da-facd27fa1ed4

📥 Commits

Reviewing files that changed from the base of the PR and between dbc25b1 and 4f50e97.

📒 Files selected for processing (1)

• Web/Resgrid.Web.Tts/Dockerfile

[ucswift]

Approve

[github-actions]

This PR is approved.