Skip to content

RE1-T119 Build fix#386

Merged
ucswift merged 1 commit into
masterfrom
develop
May 15, 2026
Merged

RE1-T119 Build fix#386
ucswift merged 1 commit into
masterfrom
develop

Conversation

@ucswift
Copy link
Copy Markdown
Member

@ucswift ucswift commented May 15, 2026

Summary by CodeRabbit

  • Bug Fixes
    • Fixed FFmpeg extraction during Docker image build to properly decompress archived files.

Review Change Stack

@request-info
Copy link
Copy Markdown

request-info Bot commented May 15, 2026

Thanks for opening this, but we'd appreciate a little more information. Could you update it with more details?

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 4ebaef60-f378-47e5-9b66-2f05a364f824

📥 Commits

Reviewing files that changed from the base of the PR and between 700ae88 and 09b2e1b.

📒 Files selected for processing (1)
  • Web/Resgrid.Web.Tts/Dockerfile

📝 Walkthrough

Walkthrough

The FFmpeg installation in the Docker publish stage is corrected to properly decompress .tar.xz archives by changing the tar command flags from -xf to -xJf, ensuring correct extraction of the .xz-compressed tarball.

Changes

FFmpeg Archive Extraction

Layer / File(s) Summary
FFmpeg tar extraction command fix
Web/Resgrid.Web.Tts/Dockerfile
The tar extraction command is updated from tar -xf to tar -xJf to ensure the .xz archive is decompressed during extraction.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Resgrid/Core#384: Both PRs modify the same Web/Resgrid.Web.Tts/Dockerfile publish stage FFmpeg installation logic, with this PR fixing tar extraction decompression flags.
  • Resgrid/Core#385: Both PRs modify the Web/Resgrid.Web.Tts/Dockerfile publish stage FFmpeg installation by addressing how the downloaded tarball is extracted.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title references a ticket identifier (RE1-T119) but provides minimal context about the actual change; the word 'Build fix' is too generic to clearly convey that this fixes FFmpeg extraction in a Docker build. Consider a more descriptive title like 'Fix FFmpeg extraction in Docker build for TTS service' to make the specific nature of the build fix immediately clear without needing to reference the ticket.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ucswift
Copy link
Copy Markdown
Member Author

ucswift commented May 15, 2026

Approve

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is approved.

@ucswift ucswift merged commit 5fcb108 into master May 15, 2026
19 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant