build(deps): drop Angular Material + Bootstrap, enable Preflight (migration complete)#157
Merged
gkbishnoi07 merged 8 commits intoJul 9, 2026
Conversation
…ight The final migration step - the app is now 100% Zard UI + Tailwind: - replace MatTableDataSource with a local TableDataSource (same surface: data/filter/filteredData/filterPredicate/paginator; data reflects the active filter, matching what mat-table rendered); drop the dead @ViewChild(MatPaginator) declarations (39 + 25 files) - remove @angular/material and bootstrap from package.json (@angular/cdk stays - it is the primitives layer Zard UI is built on) - angular.json: remove the Material prebuilt theme and the bootstrap script/style entries; delete src/bootstrap.layer.css (nothing left to layer); remove the bootstrap bundle script from index.html - styles.css: remove the coexistence [z-button]/z-select radius reset (Material's unlayered button rule is gone) - tailwind.css: enable Preflight in @layer base and add the shadcn default border color (* { border-color: var(--border) }) so bare border utilities render the subtle token instead of currentColor Verified: dev + prod builds green, lint 0 errors; compiled bundle has preflight active, the border-color base rule, and zero --bs- variables.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The main-store indent order worklist template uses *ngFor but the component never imported NgFor (NG8103) - the table rows silently did not render. Also removes the unused NgClass import flagged by NG8113 in rx-item-dispense.
Drop the app-footer component and its usages (login, reset/set-password, facility-selection, service, dashboard, rx-dashboard). Same decision as MMU-UI: no global footer bar in the migrated UI; the Powered by / copyright / online-status strip goes away.
…the header
provideZard() (Zard's custom event-manager plugins - .outside, {key},
.debounce template event syntax) was never added to main.ts during the
Tailwind/Zard setup, so the date-picker's popover close/toggle bindings were
dead and the calendar could not open. Same provider MMU-UI registers.
The header logo switches from logo.png (white variant designed for the old
dark navbar, invisible on the new white header) to the colored Swasthya.png
used by the login screen and MMU-UI's header.
…logo) Replace the outline icon tile with MMU-UI's exact service tile: a primary (brand blue) z-button with the service image (assets/images/<name>.png) and large label, in a max-w-lg centered card with the same entrance animation.
Swap the MMU van image back to the lucideStore icon (this is the inventory store service), sized via the button's --ng-icon__size on the same primary blue tile.
Drop the service-name text from the tile (kept as the button's aria-label) and size the store icon up to 80px via the icon's size input.
Advances the submodule to da84760: form messages use text-destructive/ text-success theme tokens (was raw red/green classes) and table headers match stock shadcn TableHead (font-medium text-foreground, was bold muted).
|
drtechie
approved these changes
Jul 6, 2026
gkbishnoi07
changed the base branch from
feat/phase4-zard-dialogs
to
angular-zard-migration
July 9, 2026 06:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #156 (Zard dialogs). The final migration PR — Inventory-UI is now 100% Zard UI + Tailwind v4: 0 Angular Material, 0 Bootstrap.
What this does
MatTableDataSource→ localTableDataSource(same surface —data/filter/filteredData/filterPredicate/paginator;datareflects the active filter, matching whatmat-tableused to render); dead@ViewChild(MatPaginator)declarations removed (39 + 25 files)@angular/materialandbootstrapremoved frompackage.json—@angular/cdkstays (it's the primitives layer Zard UI itself is built on, per Zard's own dependencies)angular.json/index.html;bootstrap.layer.cssdeleted (nothing left to layer)[z-button]radius reset removed (the unlayered Materialbutton{border-radius:0}is gone)@layer base) with shadcn's default border color* { border-color: var(--border) }— bareborderutilities render the subtle token, not near-blackcurrentColorVerified
build-dev✅ ·build-prod✅ ·lint0 errors ✅ · compiled bundle: preflight active, border-color base rule present, zero--bs-variables, Material/Bootstrap absent from depsFull chain (merge bottom-up)
#146 Angular 16→20 → #147 standalone → #148 Tailwind+Zard setup → #149 shell+auth → #150 entry flows → #151 reports → #152 stock ops → #153 dispense+rx → #154 indent+returns → #155 core widgets → #156 Zard dialogs → this PR