Skip to content

feat(ui): migrate indent + patient-return flows (17 components) to Zard UI#154

Merged
gkbishnoi07 merged 1 commit into
angular-zard-migrationfrom
feat/migrate-indent-returns
Jul 9, 2026
Merged

feat(ui): migrate indent + patient-return flows (17 components) to Zard UI#154
gkbishnoi07 merged 1 commit into
angular-zard-migrationfrom
feat/migrate-indent-returns

Conversation

@gkbishnoi07

Copy link
Copy Markdown

Stacked on #153 (dispense+rx). Migrates the indent and patient-return flows (17 components) to Zard UI + Tailwind v4 — zero Material/Bootstrap presentation; FormArray, dialog and service logic verbatim.

Screens

  • indent: order worklists (main/sub-store), indent-dispenses (manual + select-batch-for-indent-item, system + show-indent-batch-details), item models, reject dialog, indent-request entry grid
  • patient-return: main screen + beneficiary-details, item/batch-details, previous-records

Notable (flagged)

  • Latent bug fixed: matDialogClose="false" closed select-batch's OK with the truthy string 'false' (opener's if (result) would treat it as success) — now closes with boolean false
  • Object-valued mat-selects → index-bind + patch pattern (4 selects); the required attr on those no longer adds a reactive validator, but gating still holds via the batch-dependent required quantity controls
  • Template-only z-paginator (zero TS change); tables where mat-paginator was decorative now actually paginate, with global serial numbers preserved
  • Read-only date cells render control.value | date without rebinding, keeping save payloads identical
  • Mat-opened dialogs keep MatDialogRef (Phase 4 migrates the opener)

build-dev ✅ · prettier/eslint ✅ · 17 component CSS files deleted

17 components: indent order worklists (main/sub-store), indent-dispenses
(manual + select-batch-for-indent-item, system + show-indent-batch-details),
item models, reject dialog, indent-request entry grid; patient-return (+
beneficiary details, item/batch details, previous records).

- worklists -> z-card/z-table with template-only z-paginator; entry grids
  keep FormArray bindings verbatim; object-valued selects use the index-bind
  + patch pattern; z-date-picker for date fields
- Mat-opened dialogs keep MatDialogRef with the neutral dialog header
- fixes a latent bug: matDialogClose="false" closed with the truthy string
  'false'; now closes with boolean false like the header close
- bogus [formGroup] bindings on read-only display cells dropped

Zero Material / zero Bootstrap presentation; 17 component CSS files deleted.
@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 452283da-4673-429d-96d4-6b85d9efdf01

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Jul 6, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
4.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@gkbishnoi07
gkbishnoi07 changed the base branch from feat/migrate-dispense-rx to angular-zard-migration July 9, 2026 06:38
@gkbishnoi07
gkbishnoi07 merged commit fd9367e into angular-zard-migration Jul 9, 2026
3 of 4 checks passed
@gkbishnoi07
gkbishnoi07 deleted the feat/migrate-indent-returns branch July 9, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants