refactor(dialog): MatDialog to ZardDialogService across the app (Phase 4a)#156
Conversation
…ogService 54 files - the last functional Material usage in the app: - ConfirmationService rewritten on the MMU-UI pattern (shared createDialog helper; all 8 methods set componentInstance fields and return afterClosed()) - TextareaDialog + rx-batchview services and all 24 open() call sites (17 components + 7 directives): open -> create with data->zData, width->zWidth, disableClose->zMaskClosable(+ref.disableClose for the session-timeout dialog, blocking Escape as before) - 26 dialog content components: MatDialogRef -> ZardDialogRef, MAT_DIALOG_DATA -> Z_MODAL_DATA; template-facing property names unchanged - main.ts: MatDialogModule + MatDatepickerModule providers removed height/panelClass options dropped (Zard dialogs auto-size, as in MMU-UI). MatTableDataSource/MatPaginator remain as plain data structures only. Dev build verified green.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Stacked on #155 (core widgets). Phase 4a: migrates the entire dialog layer from
MatDialogtoZardDialogService— the last functional Material usage in the app (54 files).createDialoghelper,componentInstance!config,afterClosed()semantics identical)open()call sites (17 components + 7 directives):data→zData,width→zWidth,disableClose→zMaskClosable+ref.disableClosefor the session-timeout dialog (Escape blocked, as before)MatDialogRef→ZardDialogRef,MAT_DIALOG_DATA→Z_MODAL_DATA; template-facing property names unchangedmain.ts:MatDialogModule/MatDatepickerModuleproviders removed306f09b) already contains the route-scoped-provider fix, and all app services are root-provided — no NG0201 class of issuesFlagged:
height/panelClassoptions dropped (Zard auto-sizes — same as MMU);textarea-dialog'sbackdropClick()close-with-data subscription removed (ZardDialogRefhas no backdropClick; the service has zero callers).After this PR the only
@angular/materialleft isMatTableDataSource/MatPaginatoras data structures — removed with the dependency itself in the final Phase-4b PR.build-dev✅ · eslint/prettier ✅