Skip to content

feat(ui): migrate stock-operations screens (14 components) to Zard UI#152

Merged
gkbishnoi07 merged 1 commit into
angular-zard-migrationfrom
feat/migrate-stock-ops
Jul 9, 2026
Merged

feat(ui): migrate stock-operations screens (14 components) to Zard UI#152
gkbishnoi07 merged 1 commit into
angular-zard-migrationfrom
feat/migrate-stock-ops

Conversation

@gkbishnoi07

Copy link
Copy Markdown

Stacked on #151 (reports). Migrates the four stock-operations flows (14 components) to Zard UI + Tailwind v4 — zero Material, zero Bootstrap in every template; all FormArray/validation/dialog logic verbatim.

Screens

  • physical-stock-entry + view + details dialog
  • store-stock-adjustment (+ drafts, 4 view/detail screens)
  • store-stock-transfer (+ views/details)
  • store-self-consumption (+ views/details)

Key decisions (flagged)

  • Pagination: template-only z-paginator over the existing MatTableDataSource.data — zero TS changes (@ViewChild(MatPaginator) stays null-safe)
  • transferTo select holds an object → index-bind + patchValue pattern (same as facility-selection); adjustmentType (strings) binds formControlName directly
  • z-date-picker CVA: formControlName/ngModel verbatim; preventTyping handler dropped (trigger is a button — typing impossible; keeping it would block keyboard activation)
  • Detail dialogs stay MatDialog-opened (Phase 4 migrates the opener); neutral shadcn dialog headers replace the hex-blue banner
  • Transfer in/out row markers: hex → border-l-primary / border-l-warning tokens

build-dev ✅ · eslint/prettier ✅ · component CSS deleted

14 components: physical-stock-entry (+view/details), store-stock-adjustment
(+drafts and 4 view/detail screens), store-stock-transfer (+views/details),
store-self-consumption (+views/details).

- FormArray item grids -> z-table rows with z-input/z-select cells; every
  formArrayName/index binding, directive (appItemSearch/appBatchAdjustment/
  appBatchSearch) and validation kept verbatim
- mat-datepicker -> z-date-picker (CVA; min/max -> minDate/maxDate)
- adjustmentType binds formControlName directly (strings); transferTo holds
  an OBJECT so it uses the index-bind + patchValue pattern
- Mat-opened detail dialogs keep MatDialogRef; neutral shadcn dialog headers
- pagination via template-only z-paginator over the existing
  MatTableDataSource.data - zero TS changes
- transfer-in/out markers -> border-l-primary/warning tokens (was hex)

Zero Material / zero Bootstrap in all 14 templates; component CSS deleted.
@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7660ef33-d8f6-4899-88ae-2704c267b43a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Jul 5, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
16.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@gkbishnoi07
gkbishnoi07 changed the base branch from feat/migrate-reports to angular-zard-migration July 9, 2026 06:36
@gkbishnoi07
gkbishnoi07 merged commit 8307370 into angular-zard-migration Jul 9, 2026
3 of 4 checks passed
@gkbishnoi07
gkbishnoi07 deleted the feat/migrate-stock-ops branch July 9, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants