merge master#109
Merged
Merged
Conversation
* [DLMED] add AutoAdjustChannel transform Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] add dict version transform Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> * [DLMED] fix doc-build issue Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] fix flake8 issue Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] fix flake8 issue Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] update according to Wenqi's comments Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] update doc-strings Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
Allow missing keys
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
* Update load pretrain for densenet Signed-off-by: Yiheng Wang <vennw@nvidia.com> * Fix isort issue Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
* [DLMED] add suqeeze to handler Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] update according to comments Signed-off-by: Nic Ma <nma@nvidia.com>
* fixes #1285 Signed-off-by: Wenqi Li <wenqil@nvidia.com> * adds test Signed-off-by: Wenqi Li <wenqil@nvidia.com>
* fixes #1685 Signed-off-by: Wenqi Li <wenqil@nvidia.com> * add temp test Signed-off-by: Wenqi Li <wenqil@nvidia.com> * adds docstring Signed-off-by: Wenqi Li <wenqil@nvidia.com> * fixes dist sampler Signed-off-by: Wenqi Li <wenqil@nvidia.com> * remove temp tests Signed-off-by: Wenqi Li <wenqil@nvidia.com> * fixes type hint issue Signed-off-by: Wenqi Li <wenqil@nvidia.com>
* fixes data type in switching Signed-off-by: Wenqi Li <wenqil@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
* Implement CuImageReader and OpenSlideReader Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Add unittests for CuImageReader Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Add unittests for OpenSlideReader Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Sort imports Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Add correct boundaries Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Add test cases for reading patches on a grid for CuImage Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Add patch whole slide imaging dataset for pathology Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Add test case for read patches for OpenSlide Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * flake8 and few minor changes Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * black Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * flake8 Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Add kwargs to CuImageReader and OpenSlideReader's read method Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Change the type hint from np.dtype to DTypeLike Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Fix a bug Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Implement WSIReader and unittests Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Minor updates Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Fix few typing issues Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Revert datasets Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Add shape property to openslide image object Reverse size to be compatible with output size (hxw) Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Add untittest for loading the whole image Reverse the size accroding to the WSIReader Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Update the whole image size Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Remove optional size Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Remove optional dtype Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Remove _get_spatial_shape return type Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Reverse the orders of dimensions of `location` to be compatible with image shape Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Change test cases to use smaller image and revese location's dimensions Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Replace the test TIFF and some upgrades Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Update dependencies for OpenSlide Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Update unittests for OpenSlide and CuImage Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Fix openslide dependency Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Fix doc dependencies Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Minor changes Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Few variable name changes Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Add EnsureChannelFirst Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Add metadata to WSIReader Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com>
* update docstring Signed-off-by: Wenqi Li <wenqil@nvidia.com> * revise docstring Signed-off-by: Wenqi Li <wenqil@nvidia.com>
* [DLMED] add Affined transform Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
* update for torch 1.8.0 Signed-off-by: Wenqi Li <wenqil@nvidia.com> * mute codecov upload error Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
with allow_missing_keys_mode
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
* fixes #1500 update grid dataset to support patch level transforms Signed-off-by: Wenqi Li <wenqil@nvidia.com>
* [DLMED] update type of arg in workflows Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> * [DLMED] fix flake8 issue Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] fix flake8 issue Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
* 1651 implement RegUNet Signed-off-by: kate-sann5100 <yiwen.li@st-annes.ox.ac.uk>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
* Update MONAI Docker with OpenSlide dependencies Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com> * Update cron job to install apt dependencies Signed-off-by: Behrooz <3968947+behxyz@users.noreply.github.com>
* use eval for getting class_idx for gradcam
* fixes unit test Signed-off-by: Wenqi Li <wenqil@nvidia.com> * fixes timed call tests Signed-off-by: Wenqi Li <wenqil@nvidia.com>
basic inverse API
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
* [DLMED] add notnans to summary Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] fix bug in the dist test Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] enhance the percent Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> * [DLMED] update tests Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] update according to comments Signed-off-by: Nic Ma <nma@nvidia.com> Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
fix cachedataset w persistent workers problem by deep copying first non-deterministic transform
* adding proposal implementation for reg. metrics Signed-off-by: masadcv <muhammad.asad@kcl.ac.uk> * add ignite wrappers regression metrics, needs test Signed-off-by: masadcv <muhammad.asad@kcl.ac.uk> * refactoring and adding docstrings with equations Signed-off-by: masadcv <muhammad.asad@kcl.ac.uk>
* [DLMED] enhance unit test of UNet Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] enhance tests Signed-off-by: Nic Ma <nma@nvidia.com>
* [DLMED] add Invertd transform Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> * [DLMED] fix doc build Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] skip min test Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] fix flake8 issue Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> * [DLMED] fix CI test Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] enhance docs Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] enhance doc-string Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] update according to comments Signed-off-by: Nic Ma <nma@nvidia.com> Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com> Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
* [DLMED] enhance Invertd and SaveImage Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] add more test Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] remove unwanted files Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> * [DLMED] fix flake8 issue Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] enhance doc-string Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] update according to comments Signed-off-by: Nic Ma <nma@nvidia.com> Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
* Add reference for surface distance metric Signed-off-by: Yiheng Wang <vennw@nvidia.com> * Add reference for hausdorff distance Signed-off-by: Yiheng Wang <vennw@nvidia.com>
* [DLMED] add max_roi_size Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] add max_roi_size Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] optimize logic Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] update according to comments Signed-off-by: Nic Ma <nma@nvidia.com>
fix set visible devices
* better way of managing Cache Signed-off-by: Coen <coengruijt@gmail.com> * Update test_smartcachedataset.py Signed-off-by: Coen <coengruijt@gmail.com>
* fixes docstring Signed-off-by: Wenqi Li <wenqil@nvidia.com> * 2099 docstring updates Signed-off-by: Wenqi Li <wenqil@nvidia.com>
test network consistency
* enhance norm and act layers Signed-off-by: Yiheng Wang <vennw@nvidia.com> * write generic norm and act layers Signed-off-by: Yiheng Wang <vennw@nvidia.com> * Fix flake8 errors Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
gibbs transform
* enhance get layers Signed-off-by: Wenqi Li <wenqil@nvidia.com> * codeformat/typo fixes Signed-off-by: Wenqi Li <wenqil@nvidia.com> * fixes type errors Signed-off-by: Wenqi Li <wenqil@nvidia.com>
* [DLMED] add RandScaleCrop Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] update according to comments Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] update for corner case Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] fix typo Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
* Add array and dictionary based CoordConv transforms Signed-off-by: Mark <mark.graham@kcl.ac.uk> * Add comments and input checks Signed-off-by: Mark Graham <markgraham539@gmail.com> * Add docs for CoordConv Signed-off-by: Mark Graham <markgraham539@gmail.com> * Add tests for CoordConv Signed-off-by: Mark Graham <markgraham539@gmail.com> * Renames to AddCoordinateChannels and simplifies transform code Signed-off-by: Mark Graham <markgraham539@gmail.com> * Test input channel is unchanged and shorten code more Signed-off-by: Mark Graham <markgraham539@gmail.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> Co-authored-by: Richard Brown <33289025+rijobro@users.noreply.github.com> Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
* [DLMED] add CenterScaleCrop Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> * [DLMED] fix typo Signed-off-by: Nic Ma <nma@nvidia.com> Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
* [DLMED] enhance CSVSaver Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] add unit tests Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] fix test errors Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] update according to comments Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] update according to comments Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> * [DLMED] update accoring to comments Signed-off-by: Nic Ma <nma@nvidia.com> Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
* [DLMED] add meta_key arg to components Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] fix CI test Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] fix flake8 Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] update according to comments Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> * [DLMED] read-only transforms can share same meta data for keys Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] add more unit tests Signed-off-by: Nic Ma <nma@nvidia.com> Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: chaliebudd <charles.budd@kcl.ac.uk> Co-authored-by: Wenqi Li <wenqil@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description
A few sentences describing the changes proposed in this pull request.
Status
Ready/Work in progress/Hold
Types of changes
./runtests.sh --codeformat --coverage../runtests.sh --quick.make htmlcommand in thedocs/folder.