Skip to content

2099 - enhances dataloader/randomizable docstrings#2188

Merged
wyli merged 2 commits into
Project-MONAI:devfrom
wyli:fixes-typo
May 13, 2021
Merged

2099 - enhances dataloader/randomizable docstrings#2188
wyli merged 2 commits into
Project-MONAI:devfrom
wyli:fixes-typo

Conversation

@wyli

@wyli wyli commented May 13, 2021

Copy link
Copy Markdown
Contributor

Signed-off-by: Wenqi Li wenqil@nvidia.com

Description

docstring updates with a new test case.
fixes #2099

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested review from Nic-Ma, ericspod and rijobro May 13, 2021 08:49
@wyli wyli changed the title enhances dataloader/randomizable docstrings 2099 - enhances dataloader/randomizable docstrings May 13, 2021
wyli added 2 commits May 13, 2021 09:52
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>

@rijobro rijobro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wyli wyli enabled auto-merge (squash) May 13, 2021 09:27
@wyli wyli merged commit a5cf253 into Project-MONAI:dev May 13, 2021
yanielc pushed a commit to yanielc/MONAI that referenced this pull request May 13, 2021
* fixes docstring

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* 2099 docstring updates

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>
@wyli wyli deleted the fixes-typo branch May 22, 2021 22:44
wyli added a commit that referenced this pull request May 26, 2021
* fixes docstring

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* 2099 docstring updates

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request May 26, 2021
* fixes docstring

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* 2099 docstring updates

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request May 26, 2021
* fixes docstring

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* 2099 docstring updates

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request May 26, 2021
* fixes docstring

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* 2099 docstring updates

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request May 26, 2021
* fixes docstring

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* 2099 docstring updates

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MONAI dataloader does not exhibit random behaviour when using np.random

2 participants