Skip to content

enhance get layers API#2199

Merged
wyli merged 4 commits into
Project-MONAI:devfrom
wyli:enhance-layer-utils
May 14, 2021
Merged

enhance get layers API#2199
wyli merged 4 commits into
Project-MONAI:devfrom
wyli:enhance-layer-utils

Conversation

@wyli

@wyli wyli commented May 14, 2021

Copy link
Copy Markdown
Contributor

Signed-off-by: Wenqi Li wenqil@nvidia.com

follow up of #2166

Description

moved monai/networks/blocks/utils.py to monai/networks/layers/utils.py
added tests and docstrings

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@yiheng-wang-nv yiheng-wang-nv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wyli , this makes the code more generic!

wyli added 2 commits May 14, 2021 15:54
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the enhance-layer-utils branch from a3b00a1 to 67eaf72 Compare May 14, 2021 14:54
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the enhance-layer-utils branch from 67eaf72 to 14b4d81 Compare May 14, 2021 14:55
@wyli wyli enabled auto-merge (squash) May 14, 2021 16:17
@wyli wyli merged commit 95726b0 into Project-MONAI:dev May 14, 2021
@wyli wyli deleted the enhance-layer-utils branch May 22, 2021 22:44
wyli added a commit that referenced this pull request May 26, 2021
* enhance get layers

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* codeformat/typo fixes

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes type errors

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request May 26, 2021
* enhance get layers

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* codeformat/typo fixes

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes type errors

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants