2169 Support more collate and list of data#2170
Merged
Merged
Conversation
merge master
merge master
merge master
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
Hi @rijobro , This PR also added more unit tests to cover the features. Thanks. |
Contributor
Author
|
/black |
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
1 task
Contributor
Author
|
Could you please help review this PR? It mainly contains 2 features: Thanks in advance. |
Signed-off-by: Nic Ma <nma@nvidia.com>
1b2383b to
ddb9a5c
Compare
yiheng-wang-nv
approved these changes
May 11, 2021
yiheng-wang-nv
approved these changes
May 11, 2021
Signed-off-by: Nic Ma <nma@nvidia.com>
68016f7 to
7a05a16
Compare
Contributor
Author
|
/black |
rijobro
reviewed
May 11, 2021
| collate_fn: how to collate data after inverse transformations. | ||
| default won't do any collation, so the output will be a list of size batch size. | ||
| collate_fn: how to collate data after inverse transformations. default won't do any collation, | ||
| so the output will be a list of PyTorch Tensor or numpy array without batch dim. |
Contributor
There was a problem hiding this comment.
Suggested change
| so the output will be a list of PyTorch Tensor or numpy array without batch dim. | |
| so the output will be a list of length `batch`, each element consisting of PyTorch Tensor or numpy array without batch dim. |
Contributor
There was a problem hiding this comment.
Sorry @Nic-Ma was a bit late with the review. PR looks good and this suggested documentation change is trivial.
rijobro
approved these changes
May 11, 2021
yanielc
pushed a commit
to yanielc/MONAI
that referenced
this pull request
May 13, 2021
* [DLMED] enhance Invertd and SaveImage Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] add more test Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] remove unwanted files Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> * [DLMED] fix flake8 issue Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] enhance doc-string Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] update according to comments Signed-off-by: Nic Ma <nma@nvidia.com> Co-authored-by: monai-bot <monai.miccai2019@gmail.com> Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>
yanielc
pushed a commit
to yanielc/MONAI
that referenced
this pull request
May 13, 2021
* [DLMED] enhance Invertd and SaveImage Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] add more test Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] remove unwanted files Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> * [DLMED] fix flake8 issue Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] enhance doc-string Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] update according to comments Signed-off-by: Nic Ma <nma@nvidia.com> Co-authored-by: monai-bot <monai.miccai2019@gmail.com> Signed-off-by: Yaniel Cabrera <yaniel.cabrera@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2169 .
Description
This PR added support for other
collatefunctions in the invert logic and save a list of tensor data.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.