Reapply feat: Connect USD and nonUSD VBA flows#57460
Conversation
This reverts commit 0894c30.
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
…ursement-account-page-refactor
|
@paultsimura Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Hey @hungvu193! So as you probably know this PR got reverted because of the deploy blockers it caused. I wasn't able to fix them at that time as it was already late evening for me after whole day of work so decision was made to revert the PR. I've linked all the blockers it caused and added 2 new commits with fixes and 1 rebase - these are the only new things in this PR. |
|
Thanks @MrMuzyk, I'll verify these bugs and let you know |
|
@MrMuzyk To confirm, since we moved non-usd flow into separated flow, we also removed the |
|
non USD flow was built separately but it needs to have the same options and looks as USD flow in it's entry point, thus the refactor. I've extracted that Start, Continue etc. options from USD flow and created VerifiedBankAccountFlowEntryPoint.tsx component that is used as an entry point for both flows |
Status of the linked issues:✅ #57408. Test57408.mov✅ #57409 Test57409.mov✅ #57410 Test57410.movTest57413.movTest57415.mov |
hungvu193
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
- If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
Screenshots/Videos
Android: Native
Screen.Recording.2025-02-21.at.17.01.37.mov
Android: mWeb Chrome
Screen.Recording.2025-02-21.at.16.17.14.mov
iOS: Native
IOS.mov
ios1.mov
iOS: mWeb Safari
Screen.Recording.2025-02-21.at.16.05.22.mov
MacOS: Chrome / Safari
Chrome.mov
MacOS: Desktop
Desktop.mov
|
All yours @madmax330 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/madmax330 in version: 9.1.8-0 🚀
|
|
Hi @MrMuzyk For USD workspace working well. Check please video bandicam.2025-03-04.18-07-02-790.mp4For non USD workspace we see pop up that we need change the currency to USD.
Is it pass? |
|
Hi @izarutskaya. If USD flow is working well then it's a pass. Non USD flow is not enabled yet so it can't be tested. |
|
@MrMuzyk One more thing, we can not actually add a manual bank account because of the amount verification, so we can only test until that step. In the other hand, we can not add a bank account to an unverified email |
|
I think the beginning of the process was the most fragile part - it had the most changes - so if it's all working there then it's ok. Steps 2-5 are identical regardless of the picked option (plaid/manual). |
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.8-1 🚀
|
| setBankAccountSubStep(CONST.BANK_ACCOUNT.SETUP_TYPE.MANUAL); | ||
| setUSDBankAccountStep(CONST.BANK_ACCOUNT.STEP.BANK_ACCOUNT); | ||
| } else if (optionPressed.current === CONST.BANK_ACCOUNT.SUBSTEP.PLAID) { | ||
| setUSDBankAccountStep(CONST.BANK_ACCOUNT.STEP.BANK_ACCOUNT); |
There was a problem hiding this comment.
We also should set BankAccountSubStep to Plaid to avoid showing the manual step briefly. ref issue
| setUSDBankAccountStep(null); | ||
| } else { | ||
| Navigation.goBack(); | ||
| } |
There was a problem hiding this comment.
You incorrectly handled the success page back button, which caused #63123
| if (!account?.validated) { | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
We need to hide the modal here to avoid issue #73690
Explanation of Change
Reapplies changes reverted by - #57422
Original PR (#55949) caused 5 deploy blockers so it was reverted.
This PR includes fixes for all the blocker issues below that were reported while this was on staging:
#57408
#57409
#57410
#57413
#57415
None of these issues are reproducible anymore.
Changes this PR re-introduces
Fixed Issues
$ #50911
PROPOSAL:
n/a
Tests
For USD workspace:
For non USD workspace:
Offline tests
QA Steps
For USD workspace:
For non USD workspace:
Behaviour shouldn't change at all. It should work the same way as it does on production at the moment
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Recording showcasing fixes for previously reported blockers
https://github.com/user-attachments/assets/766cffd7-fc83-42c9-8180-eb83649dcedb
Android: Native
android.mp4
Android: mWeb Chrome
android.web.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios.web.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4