[$250] Bank - Validate your account page shown on navigating back from plaid

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.2.39-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://test-management.browserstack.com/projects/2219752/folder/13176691/test-cases/41236742
Email or phone of affected tester (no customers): fgg55@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Go to workspace settings
3. Tap workflow - Add BA - update to USD
4. Enter magic code
5. Tap confirm
6. Tap cross ❌ button to close
7. Tap Yes, exit

Expected Result:

Add Bank Account page must be shown on navigating back from plaid

Actual Result:

Validate your account page (Magic code not received) shown instead Add Bank Account page on navigating back from plaid

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6985464_1761555140740.Screenrecorder-2025-10-27-14-04-10-112.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021985819210920772464
• Upwork Job ID: 1985819210920772464
• Last Price Increase: 2025-11-11
• Automatic offers:
• FitseTLT | Contributor | 109478317

Issue Owner

Current Issue Owner: @AndrewGable

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Eskalifer1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank - Validate your account page shown on navigating back from plaid

What is the root cause of that problem?

Currently we doesnt close the window on submit here:

App/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx

Line 327 in accde7c

handleSubmitForm={(validateCode) => validateSecondaryLogin(loginList, contactMethod, validateCode, formatPhoneNumber)}

What changes do you think we should make in order to solve the problem?

We should close it(We can add some delay to close after navigation):

 handleSubmitForm={(validateCode) => {
                    validateSecondaryLogin(loginList, contactMethod, validateCode, formatPhoneNumber);
                    toggleValidateCodeActionModal?.(false);
                }}

If needed we can delay close to not interrupt animations

PS: We can improve this by using some other callback if necessary, or by moving the logic for closing the modal window after submit inside the component.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank - Validate your account page shown on navigating back from plaid

What is the root cause of that problem?

After the account is validated before we navigate to the next step here

App/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx

Lines 149 to 162 in a60b73b

	if (reimbursementAccountOptionPressed === CONST.BANK_ACCOUNT.SETUP_TYPE.MANUAL) {
	if (isNonUSDWorkspace) {
	setNonUSDBankAccountStep(CONST.NON_USD_BANK_ACCOUNT.STEP.COUNTRY);
	setReimbursementAccountOptionPressed(CONST.BANK_ACCOUNT.SETUP_TYPE.NONE);
	return;
	}
	prepareNextStep(CONST.BANK_ACCOUNT.SETUP_TYPE.MANUAL);
	setReimbursementAccountOptionPressed(CONST.BANK_ACCOUNT.SETUP_TYPE.NONE);
	} else if (reimbursementAccountOptionPressed === CONST.BANK_ACCOUNT.SETUP_TYPE.PLAID) {
	openPlaidView();
	prepareNextStep(CONST.BANK_ACCOUNT.SETUP_TYPE.PLAID);
	setReimbursementAccountOptionPressed(CONST.BANK_ACCOUNT.SETUP_TYPE.NONE);
	}

we haven't closed the ValidateCodeActionModal so when we navigate back it appears

What changes do you think we should make in order to solve the problem?

We should close the modal after the account is validated

        toggleValidateCodeActionModal?.(false);

What alternative solutions did you explore? (Optional)

[Nodebrute]

🚨 Edited by proposal-police: This proposal was edited at 2025-11-04 22:35:45 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Validate your account page shown on navigating back from plaid

What is the root cause of that problem?

this toggleValidateCodeActionModal comes from here

App/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx

Line 65 in dc4a796

toggleValidateCodeActionModal?: (isVisible: boolean) => void;

In ReimbursementAccount, we already set setIsValidateCodeActionModalVisible to false, but this doesn't work for the current scenario because the page remains in the stack, and we return to this page when we close Plaid.

App/src/pages/ReimbursementAccount/ReimbursementAccountPage.tsx

Line 166 in dc4a796

useBeforeRemove(() => setIsValidateCodeActionModalVisible(false));

What changes do you think we should make in order to solve the problem?

here in this useEffect we can set toggleValidateCodeActionModal?.(false); after

App/src/pages/ReimbursementAccount/VerifiedBankAccountFlowEntryPoint.tsx

Lines 145 to 148 in dc4a796

	if (!isAccountValidated) {
	return;
	}

Optional we can also check isValidateCodeActionModalVisible) and then set toggleValidateCodeActionModal?.(false). for example

// Close the validation modal when account is validated
if (isValidateCodeActionModalVisible) {
    toggleValidateCodeActionModal?.(false);
}

Note

My proposal is different from the other contributor's proposal. They are suggesting closing the modal after account validation, whereas I am suggesting closing it in an effect. My rca is also different.

What alternative solutions did you explore? (Optional)

[melvin-bot]

@abekkala Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021985819210920772464

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)