Skip to content

Revert "feat: Connect USD and nonUSD VBA flows"#57422

Merged
chiragsalian merged 1 commit into
mainfrom
revert-55949-feat/50911-continue-vbba
Feb 25, 2025
Merged

Revert "feat: Connect USD and nonUSD VBA flows"#57422
chiragsalian merged 1 commit into
mainfrom
revert-55949-feat/50911-continue-vbba

Conversation

@neil-marcellini

@neil-marcellini neil-marcellini commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

Reverts #55949. Fixes several deploy blockers.

Fixed Issues

$ #57409
$ #57413
$ #57415
$ #57408
$ #57410

@neil-marcellini neil-marcellini self-assigned this Feb 25, 2025
@neil-marcellini neil-marcellini requested a review from a team as a code owner February 25, 2025 18:18
@melvin-bot

melvin-bot Bot commented Feb 25, 2025

Copy link
Copy Markdown

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@melvin-bot melvin-bot Bot requested a review from youssef-lr February 25, 2025 18:19
@melvin-bot

melvin-bot Bot commented Feb 25, 2025

Copy link
Copy Markdown

@youssef-lr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team February 25, 2025 18:19
@MrMuzyk

MrMuzyk commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

Also fixes
#57408
#57410

@chiragsalian chiragsalian merged commit 0f5dbe8 into main Feb 25, 2025
@chiragsalian chiragsalian deleted the revert-55949-feat/50911-continue-vbba branch February 25, 2025 18:26
@melvin-bot melvin-bot Bot added the Emergency label Feb 25, 2025
@melvin-bot

melvin-bot Bot commented Feb 25, 2025

Copy link
Copy Markdown

@chiragsalian looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@chiragsalian

Copy link
Copy Markdown
Contributor

Not an emergency, straight revert so skipped checks.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Feb 25, 2025
…inue-vbba

Revert "feat: Connect USD and nonUSD VBA flows"

(cherry picked from commit 0f5dbe8)

(CP triggered by chiragsalian)
@github-actions github-actions Bot added the CP Staging marks PRs that have been CP'd to staging label Feb 25, 2025
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/chiragsalian in version: 9.1.5-4 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.5-5 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants