feat: Connect USD and nonUSD VBA flows

[MrMuzyk]

Explanation of Change

• refactor of ReimbursementAccountPage
• moved certain methods to utils
• files division that represents better existence of two flows - USD/non USD
• moved connect/continue/start over/disconnect screens to separate files. They're now common for USD/non USD flows
• default values should now be displayed correctly for Steps 1-3 in non USD flow
• connect/continue screens works for non USD flow
• default steps and sub steps are being correctly displayed for non USD flow - they reflect user progress in the flow
• fixed imports in multiple files
• got rid of deprecated HOCs like with-onyx in multiple files
• typo's fixes

Fixed Issues

$ #50911
PROPOSAL:

Tests

For USD workspace:

• Connect Plaid account
• Connect Manually account
• Connect Plaid account on unverified account (no confirmed email)
• Connect Manually account on unverified account (no confirmed email)
• Check if exiting and coming back to flow displays correct buttons and they work correctly (continue/start over/disconnect)

For non USD workspace:

• Connect Manually account (at the moment working up to step 4 included)
• Connect Manually account (at the moment working up to step 4 included) on unverified account (no confirmed email)
• Continue/Exit for each step
• Back button for each step
• Default values for each step (up to step 4 included) are displayed properly
• User returns to correct step and sub step upon pressing continue
• Verify that no errors appear in the JS console

Offline tests

QA Steps

For USD workspace:

• Connect Plaid account
• Connect Manual account
• Connect plaid account on unverified account (no confirmed email)
• Connect manual account on unverified account (no confirmed email)
• Check if exiting and coming back to flow displays correct buttons and they work correctly (continue/start over/disconnect)

For non USD workspace:

• Error message that they're not yet supported should be displayed on staging

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android.web.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios.web.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

[melvin-bot]

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

[MrMuzyk]

Do you know if he will be back on monday? No need to merge it today but would be nice to close it on monday :)

[hungvu193]

IDK 😄 . Let's wait, if he doesn't repsonse on the next Mon. I'll bump on slack 🎉

[hungvu193]

@MrMuzyk Can you resolve the conflicts?

[hungvu193]

I bumped Max on slack

[MrMuzyk]

I've resolved conflicts but changes to Mobile-Expensify shouldnt be here in the first place. Trying to sort it out now

[MrMuzyk]

Should be all good now. Waiting for a merge now

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.1.5-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

[IuliiaHerets]

Hi, @MrMuzyk . We haven't an error message that not USD currency is not yet supported, only this pop-up. Should we do some precondition steps for having it?

[IuliiaHerets]

This PR is failing because of issue #57408 and #57410

[tgolen]

@MrMuzyk I saw that you rebased this branch several times while it was under review. Once a branch has been pushed to the remote, it is against our policy to rebase it. Please discontinue that in the future. Thank you!

[MrMuzyk]

Hi, @MrMuzyk . We haven't an error message that not USD currency is not yet supported, only this pop-up. Should we do some precondition steps for having it?

@IuliiaHerets
Hi! I'm not sure if I fully understand what's the issue here. Can you post more detailed steps and description on what do you think should be happening?

[MrMuzyk]

@tgolen
We will be reverting it for now - #57422 - I apologize for the trouble

[github-actions]

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.1.5-5 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

[MrMuzyk]

Hi, @MrMuzyk . We haven't an error message that not USD currency is not yet supported, only this pop-up. Should we do some precondition steps for having it?

Hey @IuliiaHerets! I'm working through the bugs this PR caused yesterday and I wanted to ask again about this thing you've mentioned. Can you explain what exactly was wrong in your opinion here?

[IuliiaHerets]

Hi, @MrMuzyk, in PR there is a step for a non-US workspace. we should have an error message that they're not yet supported, but we haven't it, only the pop-up I mentioned, that asks us to change the currency to USD

bandicam.2025-02-26.16-15-27-780.mp4

[MrMuzyk]

I understand, bad phrasing on my end. non USD workspaces should be behaving in the exact way as they currently are on prod. I will adjust QA steps regarding this in my PR that restores these changes. Thanks!

[rojiphil]

Browser link to complete the connection with the bank failed to launch the expected page as we did not pass the policy id. We fixed this in #57587