Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
e57ee61
feat: 50911 Continue VBBA
MrMuzyk Jan 28, 2025
9644cf1
Merge branch 'feat/step-4-logic' of github.com:callstack-internal/Exp…
MrMuzyk Jan 28, 2025
8ec3072
feat: types
MrMuzyk Jan 29, 2025
630324c
feat: updated file division and removal of obsolete withOnyx
MrMuzyk Jan 29, 2025
0fcd7c4
testing
MrMuzyk Jan 30, 2025
6c00dc5
Merge branch 'feat/step-4-logic' of github.com:callstack-internal/Exp…
MrMuzyk Jan 30, 2025
81ac609
Merge branch 'main' of github.com:Expensify/App into feat/50911-conti…
MrMuzyk Jan 30, 2025
cb85edb
fix: more testing
MrMuzyk Jan 30, 2025
184be59
loader
MrMuzyk Jan 31, 2025
1259afb
Merge branch 'feat/step-4-logic' of github.com:callstack-internal/Exp…
MrMuzyk Jan 31, 2025
3f53983
break
MrMuzyk Feb 3, 2025
63b8e10
removed a page
MrMuzyk Feb 3, 2025
c4194b9
diff approach
MrMuzyk Feb 4, 2025
46afaab
feat: edge cases now
MrMuzyk Feb 4, 2025
d382ff9
Merge branch 'feat/step-4-logic' of github.com:callstack-internal/Exp…
MrMuzyk Feb 4, 2025
491730b
linter and testing
MrMuzyk Feb 4, 2025
9fba860
connected screen
MrMuzyk Feb 5, 2025
0d9fc92
more edgecases
MrMuzyk Feb 5, 2025
2a65b1a
more edgecases
MrMuzyk Feb 6, 2025
c2256f8
business info default values and some renaming
MrMuzyk Feb 6, 2025
d0f81fa
bank info default values
MrMuzyk Feb 7, 2025
952bcc6
Merge branch 'main' of github.com:Expensify/App into feat/50911-conti…
MrMuzyk Feb 7, 2025
0eda122
fix: polish
MrMuzyk Feb 10, 2025
a152135
Merge branch 'main' of github.com:Expensify/App into feat/50911-conti…
MrMuzyk Feb 10, 2025
74d1ec1
comment
MrMuzyk Feb 11, 2025
29ec0ec
feat: cut bank statement from step 2
MrMuzyk Feb 12, 2025
dd36259
Merge branch 'main' of github.com:Expensify/App into feat/50911-conti…
MrMuzyk Feb 12, 2025
7de6cce
Merge branch 'main' of github.com:Expensify/App into feat/50911-conti…
MrMuzyk Feb 17, 2025
e8ad6b6
Merge branch 'main' of github.com:Expensify/App into feat/50911-conti…
MrMuzyk Feb 20, 2025
6dfe97e
Merge branch 'main' of github.com:Expensify/App into feat/50911-conti…
MrMuzyk Feb 21, 2025
7975811
fix: display continue setup after going back
MrMuzyk Feb 21, 2025
d217d44
Merge branch 'main' of github.com:Expensify/App into feat/50911-conti…
MrMuzyk Feb 24, 2025
5778c46
fix: remove submodule changes
MrMuzyk Feb 24, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/CONST.ts
Original file line number Diff line number Diff line change
Expand Up @@ -680,6 +680,14 @@ const CONST = {
AGREEMENTS: 'AgreementsStep',
FINISH: 'FinishStep',
},
BANK_INFO_STEP_ACH_DATA_INPUT_IDS: {
ACCOUNT_HOLDER_NAME: 'addressName',
ACCOUNT_HOLDER_REGION: 'addressState',
ACCOUNT_HOLDER_CITY: 'addressCity',
ACCOUNT_HOLDER_ADDRESS: 'addressStreet',
ACCOUNT_HOLDER_POSTAL_CODE: 'addressZipCode',
ROUTING_CODE: 'routingNumber',
},
BUSINESS_INFO_STEP: {
PICKLIST: {
ANNUAL_VOLUME_RANGE: 'AnnualVolumeRange',
Expand Down
2 changes: 1 addition & 1 deletion src/components/Form/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import type TimeModalPicker from '@components/TimeModalPicker';
import type UploadFile from '@components/UploadFile';
import type ValuePicker from '@components/ValuePicker';
import type ConstantSelector from '@pages/Debug/ConstantSelector';
import type BusinessTypePicker from '@pages/ReimbursementAccount/BusinessInfo/substeps/TypeBusiness/BusinessTypePicker';
import type BusinessTypePicker from '@pages/ReimbursementAccount/USD/BusinessInfo/subSteps/TypeBusiness/BusinessTypePicker';
import type DimensionTypeSelector from '@pages/workspace/accounting/intacct/import/DimensionTypeSelector';
import type NetSuiteCustomFieldMappingPicker from '@pages/workspace/accounting/netsuite/import/NetSuiteImportCustomFieldNew/NetSuiteCustomFieldMappingPicker';
import type NetSuiteCustomListPicker from '@pages/workspace/accounting/netsuite/import/NetSuiteImportCustomFieldNew/NetSuiteCustomListPicker';
Expand Down
10 changes: 5 additions & 5 deletions src/components/SubStepForms/AddressStep.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ import Text from '@components/Text';
import useLocalize from '@hooks/useLocalize';
import type {SubStepProps} from '@hooks/useSubStep/types';
import useThemeStyles from '@hooks/useThemeStyles';
import * as ValidationUtils from '@libs/ValidationUtils';
import {getFieldRequiredErrors, isValidAddress, isValidZipCode, isValidZipCodeInternational} from '@libs/ValidationUtils';
import AddressFormFields from '@pages/ReimbursementAccount/AddressFormFields';
import HelpLinks from '@pages/ReimbursementAccount/PersonalInfo/HelpLinks';
import HelpLinks from '@pages/ReimbursementAccount/USD/Requestor/PersonalInfo/HelpLinks';
import type {OnyxFormValuesMapping} from '@src/ONYXKEYS';

type AddressValues = {
Expand Down Expand Up @@ -95,16 +95,16 @@ function AddressStep<TFormID extends keyof OnyxFormValuesMapping>({

const validate = useCallback(
(values: FormOnyxValues<TFormID>): FormInputErrors<TFormID> => {
const errors = ValidationUtils.getFieldRequiredErrors(values, stepFields);
const errors = getFieldRequiredErrors(values, stepFields);

const street = values[inputFieldsIDs.street as keyof typeof values];
if (street && !ValidationUtils.isValidAddress(street as FormValue)) {
if (street && !isValidAddress(street as FormValue)) {
// @ts-expect-error type mismatch to be fixed
errors[inputFieldsIDs.street] = translate('bankAccount.error.addressStreet');
}

const zipCode = values[inputFieldsIDs.zipCode as keyof typeof values];
if (zipCode && (shouldDisplayCountrySelector ? !ValidationUtils.isValidZipCodeInternational(zipCode as string) : !ValidationUtils.isValidZipCode(zipCode as string))) {
if (zipCode && (shouldDisplayCountrySelector ? !isValidZipCodeInternational(zipCode as string) : !isValidZipCode(zipCode as string))) {
// @ts-expect-error type mismatch to be fixed
errors[inputFieldsIDs.zipCode] = translate('bankAccount.error.zipCode');
}
Expand Down
2 changes: 1 addition & 1 deletion src/components/SubStepForms/FullNameStep.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import useLocalize from '@hooks/useLocalize';
import type {SubStepProps} from '@hooks/useSubStep/types';
import useThemeStyles from '@hooks/useThemeStyles';
import {getFieldRequiredErrors, isRequiredFulfilled, isValidLegalName} from '@libs/ValidationUtils';
import HelpLinks from '@pages/ReimbursementAccount/PersonalInfo/HelpLinks';
import HelpLinks from '@pages/ReimbursementAccount/USD/Requestor/PersonalInfo/HelpLinks';
import CONST from '@src/CONST';
import type {OnyxFormValuesMapping} from '@src/ONYXKEYS';

Expand Down
2 changes: 1 addition & 1 deletion src/components/SubStepForms/SingleFieldStep.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import TextInput from '@components/TextInput';
import useLocalize from '@hooks/useLocalize';
import type {SubStepProps} from '@hooks/useSubStep/types';
import useThemeStyles from '@hooks/useThemeStyles';
import HelpLinks from '@pages/ReimbursementAccount/PersonalInfo/HelpLinks';
import HelpLinks from '@pages/ReimbursementAccount/USD/Requestor/PersonalInfo/HelpLinks';
import CONST from '@src/CONST';
import type {OnyxFormValuesMapping} from '@src/ONYXKEYS';

Expand Down
2 changes: 1 addition & 1 deletion src/libs/API/parameters/RestartBankAccountSetupParams.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
type RestartBankAccountSetupParams = {
bankAccountID: number;
ownerEmail: string;
policyID: string;
policyID: string | undefined;
};

export default RestartBankAccountSetupParams;
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Onyx.connect({
/**
* Reset user's reimbursement account. This will delete the bank account.
*/
function resetFreePlanBankAccount(bankAccountID: number | undefined, session: OnyxEntry<OnyxTypes.Session>, policyID: string) {
function resetFreePlanBankAccount(bankAccountID: number | undefined, session: OnyxEntry<OnyxTypes.Session>, policyID: string | undefined) {
if (!bankAccountID) {
throw new Error('Missing bankAccountID when attempting to reset free plan bank account');
}
Expand Down
15 changes: 0 additions & 15 deletions src/pages/ReimbursementAccount/ACHContractStep.tsx

This file was deleted.

1 change: 1 addition & 0 deletions src/pages/ReimbursementAccount/AddressFormFields.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ function AddressFormFields({
modalHeaderTitle={translate('countryStep.selectCountry')}
searchInputTitle={translate('countryStep.findCountry')}
value={values?.country}
defaultValue={defaultValues?.country}
onValueChange={handleCountryChange}
stateInputIDToReset={inputKeys.state ?? 'stateInput'}
/>
Expand Down
251 changes: 0 additions & 251 deletions src/pages/ReimbursementAccount/BankAccountStep.tsx

This file was deleted.

15 changes: 0 additions & 15 deletions src/pages/ReimbursementAccount/CompanyStep.tsx

This file was deleted.

Loading