Deploy Checklist: New Expensify 2021-10-07

[OSBotify]

Release Version: 1.1.7-24
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Add inline errors to workspace modal #5560
• Refactor workspace settings #5642
• [N6.1] Use Google AddressSearch component in VBA Company Step #5643
• Payments page blank issue. #5663
• Update Paypal icon to remove white bg #5666
• [No QA] Add contributing guideline note about unique proposals #5688
• [Internal QA] Fixes detox binary path #5700
• Add shouldCreateNewPolicy param to getPolicySummaries action #5706
• [NO QA] Improve workspace welcome note #5714
• Fix invite page not loading after creating new workspace #5729
• Route to the main workspace screen now that it is in rightpane #5747
• Fix output currency #5749
• Workspace pages copy changes and growl on save #5759
• Set loading to false when requestorStep is submittted #5763
• [N6] Use AddressSearch for identity form #5770
• Do not always clear Onyx VBA data when accessing workspace sections #5771
• Show growl when clicking on links in offline mode #5776
• Close sidebar when going to concierge chat #5779
• Only show fancy loading page when we are submitting verifications #5787
• Prevent tappable bank account in EnableStep #5796
• [CP-stag] Get CompanyAddress field to autofill and show errors #5800
• Open OldDot links on Safari #5802
• Don't dismiss the Reimbursement Account Page after validating a withdrawal account #5803
• Fix link to OldDot's reports page #5813
• Use showStates in report params so that report state filters work in OldDot #5829
• Close AddressSearch results on blur #5832
• Only accept "address" result from google API - validate address_components before using it #5854
• Load policy list when url from Linking.getInitialURL is not available #5868

Deploy Blockers:

• mWeb - VBA - Address suggestion not displayed for company info #5724
• Workspace - Desktop - Blank page is displayed after click on the "Invite" button #5727
• Workspace - Unlock feature is briefly visible after adding a bank account and unlocking all features #5760
• Getting 404 error when submttting company info step #5761
• mWeb/Safari - 1.1.7.6 - Settings - Workspace - View bills and view invoices external links are not working #5798
• Settings - Workspace - Reimbursement receipts link opens to a blank page in OldDot #5799
• VBA - Error message for manually entered address in the field in company info and unable to proceed #5841
• Existing Workspaces are not displayed in mobile apps #5865

cc @Expensify/applauseleads

[mvtglobally]

starting QA

[isagoico]

Regression is almost finished, a few steps missing in TestRail. Here's a summary so far:

1. Workspace - Able to add Chronos and Concierge to workspace and unable to remove #5723
2. mWeb - VBA - Address suggestion not displayed for company info #5724 - issue is failing [N6.1] Use Google AddressSearch component in VBA Company Step #5643
3. Workspace - Desktop - Blank page is displayed after click on the "Invite" button #5727 - issue is failing Add inline errors to workspace modal #5560 in Desktop (Being fixed here Fix invite page not loading after creating new workspace #5729)

Will update here once regression is done

[isagoico]

Retests of both deploy blockers were a pass! Checking them off

Only missing PR is #5700 (CC @luacmartins @thienlnam)

[AndrewGable]

Looks like #5700 if good here #5700 (comment)

Are we OK to deploy @isagoico ?

[isagoico]

@AndrewGable Looks like 2 PRs were CPd to staging a bit ago:

1. Refactor workspace settings #5642
2. Fix output currency #5749

Going to run QA and post the results here.

[AndrewGable]

Thank you!

[isagoico]

I thought I had posted the results of the retest here yesterday:

1. Refactor workspace settings #5642 - is failing because of this visual issue Workspace - Unlock feature is briefly visible after adding a bank account and unlocking all features #5760
2. Fix output currency #5749 - Was a pass 🎉

[isagoico]

Testing both #5776 and #5779 atm

[isagoico]

@AndrewGable We were going to test on Android #5776 and the latest build available was 1.1.7-3. Not sure why 1.1.7-6 it's not showing since it succeeded to deploy according to this comment #5779 (comment)

[isagoico]

We found both this issues while testing #5776:

• mWeb/Safari - 1.1.7.6 - Settings - Workspace - View bills and view invoices external links are not working #5798
• Settings - Workspace - Reimbursement receipts link opens to a blank page in OldDot #5799

#5779 was a pass! Checking it off 🎉

[francoisl]

Hi @isagoico, the blocker #5799 should be fixed now, can you test again please?