[NO QA] Improve workspace welcome note#5714
Merged
Merged
Conversation
Contributor
Author
|
Ready for review 👍 (added the spanish translation late, oops!) |
TomatoToaster
approved these changes
Oct 7, 2021
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
36 tasks
Contributor
|
🚀 Deployed to staging by @TomatoToaster in version: 1.1.7-0 🚀
|
Contributor
|
🚀 Deployed to production by @AndrewGable in version: 1.1.7-24 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
We default to adding "workspace" to the end of a new workspace name, which makes the welcome message read "You have been invited to (someone)'s workspace workspace..."
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/179319
Tests
bwmto send the shared workspace email notificationQA Steps
Not needed, just a small copy change
Tested On
Screenshots
Web
Note: only the bottom circled text is fixed in this PR, the email subject will be fixed in Web-E
Mobile Web
Desktop
iOS
Android