Payments page blank issue.#5663
Merged
Jag96 merged 2 commits intoOct 6, 2021
Merged
Conversation
Jag96
suggested changes
Oct 6, 2021
Jag96
left a comment
Contributor
There was a problem hiding this comment.
Tested and this works well, just one request
Jag96
approved these changes
Oct 6, 2021
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
36 tasks
Contributor
|
@Santhosh-Sellavel @Jag96 On what platforms do you want us to QA this PR on? |
Collaborator
Author
|
iOS, Android & web should be enough. |
Contributor
|
🚀 Deployed to production by @AndrewGable in version: 1.1.7-24 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Directly accessing
bankNameproperty onbankAccount.additionalDataobject causes the crash, becauseadditionalDatamay be undefined sometimes. So done optional data handling usingunderscorelibraryFixed Issues
$ #5601
Tests & QA Steps
Tested On
Note: I don't have any accounts with bank account. So kindly test using the steps mentioned above
Screenshots
Web
Mobile Web
Desktop
iOS
Android