Skip to content

[Internal QA] Fixes detox binary path#5700

Merged
luacmartins merged 1 commit into
mainfrom
cmartins-detoxBinaryPath
Oct 6, 2021
Merged

[Internal QA] Fixes detox binary path#5700
luacmartins merged 1 commit into
mainfrom
cmartins-detoxBinaryPath

Conversation

@luacmartins

Copy link
Copy Markdown
Contributor

Details

Fixes detox binary path

Fixed Issues

$ #5698

Tests

  1. cd ~/App
  2. npm run detox-build
  3. npm run detox-test
  4. Verify that the tests run and succeed.

QA Steps

Internal QA. Steps above.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@luacmartins luacmartins requested a review from a team as a code owner October 6, 2021 19:31
@luacmartins luacmartins self-assigned this Oct 6, 2021
@botify

botify commented Oct 6, 2021

Copy link
Copy Markdown

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

@MelvinBot MelvinBot requested review from thienlnam and removed request for a team October 6, 2021 19:31
@luacmartins

Copy link
Copy Markdown
Contributor Author

Self-merging because it has been approved!

@luacmartins luacmartins merged commit 039216a into main Oct 6, 2021
@luacmartins luacmartins deleted the cmartins-detoxBinaryPath branch October 6, 2021 22:40
@OSBotify

OSBotify commented Oct 6, 2021

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Oct 7, 2021

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @luacmartins in version: 1.1.6-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@luacmartins

luacmartins commented Oct 11, 2021

Copy link
Copy Markdown
Contributor Author

@isagoico staging test is a pass!

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.7-24 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants