Add support for Child Themes #726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@jaxwilko Do we want this PR for 1.2.1 since it's still a draft? |
Member
Author
|
@mjauvin still got some bugs that need to be fixed before it's ready for review :) |
Member
|
So it's mostly done, just has a few glitches? |
Member
|
@mjauvin this functionality is needed for our project that we're launching in November so what release it's tagged for doesn't really matter since it'll be merged when it's ready. Don't consider it blocking against 1.2.1 though. |
LukeTowers
pushed a commit
to wintercms/storm
that referenced
this pull request
Oct 9, 2022
Instead of using 4 characters split across two folders for avoiding cache conflicts just use the relative path to the file directly. Also makes it easier to find files in the cache when debugging
Also performs the sync with model instances rather than just raw IDs to support relationships with a custom relatedKey set (the key on the related model's table that is stored on the pivot table to connect the relationship, normally just the primary key but can be anything).
…d-themes-luke * commit '966edea734a0e330f19ebe2547a1332ed39cb907': Set pivot data when initially syncing the relationship Update jobs tables to support Laravel 9 (#730) Add migrate to list of protected commands (#733) Add "Send password reset email" button to backend users update page (#723) Adjust descriptor for local event Change event doc to test new event functionality in Docs plugin Removed NPX from webpack bin call (#728) Add test case for getParentData method in AJAX framework Recompile Snowboard Allow for custom AJAX error responses to be passed through handlers Allow detached AJAX request to be called with 2 params Improve IDE knowledge of the PluginBase object Fix support for data-request-parent
* develop: Set pivot data when initially syncing the relationship (#739) Added CLI signature to mix:list command Fix Navigation Manager unit test
* develop: Set pivot data when initially syncing the relationship (#739) Added CLI signature to mix:list command Fix Navigation Manager unit test Update jobs tables to support Laravel 9 (#730) Add migrate to list of protected commands (#733) Add "Send password reset email" button to backend users update page (#723) Adjust descriptor for local event Change event doc to test new event functionality in Docs plugin Removed NPX from webpack bin call (#728) Add test case for getParentData method in AJAX framework Recompile Snowboard Allow for custom AJAX error responses to be passed through handlers Allow detached AJAX request to be called with 2 params Improve IDE knowledge of the PluginBase object Fix support for data-request-parent
…-caching [FIX] Added fix to allow nested AutoDatasource instances to manage their own populateCache
LukeTowers
reviewed
Feb 25, 2023
LukeTowers
reviewed
Feb 27, 2023
LukeTowers
reviewed
Feb 27, 2023
LukeTowers
reviewed
Feb 27, 2023
LukeTowers
reviewed
Feb 27, 2023
LukeTowers
reviewed
Feb 27, 2023
LukeTowers
requested changes
Feb 27, 2023
LukeTowers
approved these changes
Mar 1, 2023
LukeTowers
added a commit
to wintercms/docs
that referenced
this pull request
Nov 9, 2025
Documents wintercms/winter#726, replaces #252
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a theme to extend another theme via a
parent: [themeName]directive in thetheme.yaml. This PR also supports thetheme.yamlbeing added as aDbDatasourcecontent meaning that an extending theme can be purely driven by the DB.Storm PR: wintercms/storm#123