Skip to content

Conversation

@robertalexa
Copy link
Contributor

@LukeTowers This is the code we looked at together.

The fix attempts (and seems to do the job) to fix the autoloading of modules packages.

@what-the-diff
Copy link

what-the-diff bot commented Dec 8, 2022

  • Added a new line to the top of ServiceProvider.php
  • Changed foreach loop in register() method from Config::get('cms.loadModules', []) to $modules variable which was declared on line 26

@LukeTowers LukeTowers added Status: Completed maintenance PRs that fix bugs, are translation changes or make only minor changes labels Dec 8, 2022
@LukeTowers LukeTowers added this to the v1.2.2 milestone Dec 8, 2022
@LukeTowers LukeTowers merged commit d0d066f into wintercms:develop Dec 8, 2022
LukeTowers added a commit that referenced this pull request Dec 8, 2022
* develop:
  Fix issue with autoloading modules (#792)
  Add support for icon picker (#725)
  Classloader improvements (#779)
  Update Markdown content test
  Improved Ukrainian translation (#766)
  Add AJAX form validation to Snowboard (#777)
  Improve theme scaffolding (#778)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance PRs that fix bugs, are translation changes or make only minor changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants