Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #2215 +/- ##
=======================================
Coverage 28.83% 28.83%
=======================================
Files 96 96
Lines 5799 5799
Branches 2551 2551
=======================================
Hits 1672 1672
Misses 3408 3408
Partials 719 719
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9dc35e5 to
22d946a
Compare
585a27a to
50844a7
Compare
2 tasks
Collaborator
Author
|
/retest |
Collaborator
Author
|
/retest |
1 similar comment
Collaborator
Author
|
/retest |
Stringy
approved these changes
Jul 14, 2025
Collaborator
Stringy
left a comment
There was a problem hiding this comment.
This is fantastic, the build speeds are looking far, far healthier now and everything looks a lot simpler. LGTM!
Molter73
added a commit
that referenced
this pull request
Jul 15, 2025
5 tasks
Molter73
added a commit
that referenced
this pull request
Jul 15, 2025
5 tasks
Molter73
added a commit
that referenced
this pull request
Jul 18, 2025
* ROX-29116: (fix) Use ARM GH action workflow runners for ARM builds (#2106) * Revert "Revert GH arm changes (#2107)" * Add arm64 stable, beta, and dev channels for Google COS integration tests (#2096) * Use P and Z GHA runners (#2215) * Use go cross-compilation to speed up test builds on CI (#2210) After adding Arm runners on GHA, we made it so the Arm test image is always built. Unfortunately, because we use QEMU to build the images, the build has gotten quite slow. In order to speed up the build, this change makes it so we cross-compile the binaries for all our supported platforms locally and the image build simply copies the binaries into the final image. --------- Co-authored-by: Robby Cochran <rcochran@redhat.com>
Molter73
added a commit
that referenced
this pull request
Jul 18, 2025
* Use P and Z GHA runners (#2215) * Use go cross-compilation to speed up test builds on CI (#2210) After adding Arm runners on GHA, we made it so the Arm test image is always built. Unfortunately, because we use QEMU to build the images, the build has gotten quite slow. In order to speed up the build, this change makes it so we cross-compile the binaries for all our supported platforms locally and the image build simply copies the binaries into the final image.
Stringy
pushed a commit
that referenced
this pull request
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use Power and Z GHA runners provided by https://github.com/IBM/actionspz
This allows us to greatly simplify our CI workflows, since we no longer need to build images on remove VMs or have dedicated logic for running multi-arch builds conditionally. The new runners build the collector and builder images in a time frame comparable to the x86 and arm ones, so we can just run them on PRs with no major penalty.
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
CI is enough.