Add arm64 Google COS integration test#2096
Merged
robbycochran merged 3 commits intorc-fix-excludefrom May 22, 2025
Merged
Conversation
319f0c6 to
3308bb5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## rc-fix-exclude #2096 +/- ##
=================================================
Coverage ? 28.52%
=================================================
Files ? 94
Lines ? 5757
Branches ? 2547
=================================================
Hits ? 1642
Misses ? 3393
Partials ? 722
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Hey @robbycochran - I've reviewed your changes - here's some feedback:
- There’s duplicate ansible/secrets.yml generation in multiple jobs—consider extracting that into a reusable step or composite action to reduce repetition.
- The builder-tag determination logic is repeated in
collector-builder.yml; refactor it into a single shared action or step to avoid divergence. - The
ifguard was removed from thearm64-integration-testsjob—please verify it still only runs under the intended CI conditions.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Molter73
approved these changes
May 21, 2025
Collaborator
Molter73
left a comment
There was a problem hiding this comment.
LGTM!
Just 2 small comments that shouldn't block merging:
- We might want to enable the beta or dev images to have a bit of a heads up if there are breaking changes coming up, same as we have for x86
- Looking at the collector logs, there is no mention of the architecture we are running on, we might want to add something to the
Kernel Versionline to ensure we have that information available.
[INFO 2025/05/20 23:24:34] Collector Version: 3.21.x-84-g66826e8c6a-fast
[INFO 2025/05/20 23:24:34] OS: Container-Optimized OS from Google
[INFO 2025/05/20 23:24:34] Kernel Version: 6.6.87+
robbycochran
added a commit
that referenced
this pull request
May 23, 2025
Molter73
pushed a commit
that referenced
this pull request
Jul 15, 2025
Molter73
added a commit
that referenced
this pull request
Jul 18, 2025
* ROX-29116: (fix) Use ARM GH action workflow runners for ARM builds (#2106) * Revert "Revert GH arm changes (#2107)" * Add arm64 stable, beta, and dev channels for Google COS integration tests (#2096) * Use P and Z GHA runners (#2215) * Use go cross-compilation to speed up test builds on CI (#2210) After adding Arm runners on GHA, we made it so the Arm test image is always built. Unfortunately, because we use QEMU to build the images, the build has gotten quite slow. In order to speed up the build, this change makes it so we cross-compile the binaries for all our supported platforms locally and the image build simply copies the binaries into the final image. --------- Co-authored-by: Robby Cochran <rcochran@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add integration test for COS arm64
Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
CI passing is sufficient: https://github.com/stackrox/collector/actions/runs/15148620044/job/42590584829?pr=2096